Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 154932 - media-sound/fluidsynth-1.0.7 ebuild enhancements
Summary: media-sound/fluidsynth-1.0.7 ebuild enhancements
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High normal
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-11-12 13:36 UTC by Alessio Cassibba (X-Drum)
Modified: 2007-06-20 14:29 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild patch from 1.0.7 (ebuild_1.0.7.diff,1.95 KB, patch)
2006-11-12 13:37 UTC, Alessio Cassibba (X-Drum)
Details | Diff
corrected patch (ebuild.patch,1.60 KB, patch)
2007-01-23 19:37 UTC, Paweł Hajdan, Jr. (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alessio Cassibba (X-Drum) 2006-11-12 13:36:32 UTC
some ebuild enhancements:
-fixed jack support (dep use)
-fixed use handling
Comment 1 Alessio Cassibba (X-Drum) 2006-11-12 13:37:50 UTC
Created attachment 101778 [details, diff]
ebuild patch from 1.0.7

ebuild 1.0.7 patch, some enhancements
Comment 2 Diego Elio Pettenò (RETIRED) gentoo-dev 2006-11-13 07:52:25 UTC
Thanks for the patch, but it's not yet ready for commit:

- when enabling lash and not enabling alsa, the ebuild should not die (don't tell me, I'd prefer it to die, but that's the policy), so it should indeed warn, but not fail, instead it should either enable ALSA silently (preferred) or disable lash altogether;
- no need for the double flags on use_enable when they are the same;
- is static useflag used to generate static libraries or static executable? if it's for static libraries, remove the useflag and let it always build static libraries aside from shared ones;
- coreaudio is OSX stuff, leave it disabled until the ebuild is picked up by the OSX guys.
Comment 3 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2007-01-23 19:37:07 UTC
Created attachment 107926 [details, diff]
corrected patch
Comment 4 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2007-01-23 19:41:23 UTC
Looks like the reporter didn't provide corrected version of the patch, so I created my own.

Notes:
- preserved most ideas of original patch
- ebuild doesn't die, only prints a warning
- corrected double flags in use_enable
- static USE-flag was there before; didn't touch it
- removed coreaudio from previous patch
- looks like the ./configure script ignores use_enable for alsa and oss
- I'm not sure about --disable-ladcca option passed to econf; it was in the previous patch so I preserved it
Comment 5 Diego Elio Pettenò (RETIRED) gentoo-dev 2007-06-20 14:29:24 UTC
I've reworked the patch a bit, cleaned up the ebuild a bit, and committed it in 1.0.7a.