Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 154759 - app-emacs/emacs-w3m-1.4.4-r1 bad build_with_use check
Summary: app-emacs/emacs-w3m-1.4.4-r1 bad build_with_use check
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: Low minor (vote)
Assignee: Emacs project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-11-11 00:03 UTC by pflm52td
Modified: 2006-11-17 02:17 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description pflm52td 2006-11-11 00:03:38 UTC
Hi. There's an implicit dependency error in app-emacs/emacs-w3m-1.4.4-r1 (the latest ebuild). It is introduced newly in this version. 

First, as the half answer, let's see the ebuild. In pkg_setup() function, a line reads:

if built_with_use www-client/w3m async; then

The correct code should be something like:

if is_installed www-client/w3m &&
   built_with_use www-client/w3m async; then
# or 
if is_installed www-client/w3mmee ||
   built_with_use www-client/w3m async; then

I couldn't figure out the desired function, so I just name it as "is_installed".

Let me explain. The package depends on virtual/w3m. There're two ebuilds which provide it; they're www-client/w3m and www-client/w3mmee.

The ebuild refuses the case where w3m is built with async flag on. It's OK. On the other hand, a user must be able to choose w3mmee without having w3m. This case is forgotten, because built_with_use assumes that www-client/w3m is installed.

Since w3mmee does not have async flag, the above is enough.

Thanks a lot for your commitment.
Comment 1 Jakub Moc (RETIRED) gentoo-dev 2006-11-11 01:17:52 UTC
(In reply to comment #0)
> The correct code should be something like:

has_version is the right one ;)
Comment 2 Christian Faulhammer (RETIRED) gentoo-dev 2006-11-17 02:17:26 UTC
Thanks for the info, fixed in CVS.