KDEPrint in kdelibs-3.5.5-r5 with CUPS 1.2.x is still broken... and I am coming with one and maybe another one solution. the current cupsd patch in kdelibs is still not enough to solve the problem, well... frankly, it does not solve anything. So I started to lurk inside the current ubuntu patchset and I noticed that there are a lot of CUPS patches to get it working nicely with KDEPrint that are not applied in the current gentoo ebuild. So, I stripped down all their loong loong .diff file and created the attached one. It works flawlessly on all the gentoo box here and, as I said above, IT IS needed to get all working. Moreover, I noticed that in kdelibs-3.5-patchset-05.tar.bz2, there are maybe more or less the same kubuntu patches, but they're not applied ATM: phobos distfiles # tar xvjf kdelibs-3.5-patchset-05.tar.bz2 patches/ patches/kdelibs-3.5.3-misc-fixes.diff patches/kdelibs_3.5.4-kssl-3des.patch patches/kdelibs-3.5-kicker-crash.patch patches/kdelibs-3.5.3-return_val_check.diff patches/kdelibs-3.5.3-kate-fixes.diff patches/kdelibs-3.5-cupsd_init_gentoo.diff patches/kdelibs-3.5.4-libutempter.diff patches/kdelibs-3.5.4-misc-fixes.diff patches/kdelibs-3.5-bindnow.patch patches/kdelibs-3.5.4-kio-fixes.diff patches/kdelibs-3.5.4-kate-fixes.diff patches/kdelibs-3.5.2-kssl-3des.patch patches/kdelibs-3.5.3-kio-fixes.diff kdeprint-3.5.2-cups-1.2-patches/ kdeprint-3.5.2-cups-1.2-patches/kubuntu_43_cups12_empty_printers.diff kdeprint-3.5.2-cups-1.2-patches/kubuntu_39_cups12_compile_fixes.diff kdeprint-3.5.2-cups-1.2-patches/kubuntu_47_cups12_list_ignore_warnings.diff kdeprint-3.5.2-cups-1.2-patches/kubuntu_48_cups12_cupsdconf.diff kdeprint-3.5.2-cups-1.2-patches/kubuntu_40_cups12_remove_async.diff kdeprint-3.5.2-cups-1.2-patches/kubuntu_41_cups12_startstopfix.diff kdeprint-3.5.2-cups-1.2-patches/kubuntu_42_cups12_addmodify.diff Anyway, just grab the patch attached, review and please, commit ASAP :( since there are many people that can't manage their printers with KDE+CUPS 1.2. The new ebuild (based on the one on gentoo-xeffects) is in "sabayon" overlay.
Created attachment 101550 [details, diff] kdelibs-3.5.5 patch imported from Kubuntu
what does this patch do to cups 1.1.x? Does this one only work for 1.2?
I can't test that but from what I've seen, cups 1.1.x compat has been kept. Anyway, I am adding my current patches, well... this does not remove the odd warning about IPP communication but if you add/remove/change printers, it works, at least.
Created attachment 101781 [details, diff] kdelibs-3.5.5 patch taken from Kubuntu .diff
This patch doesn't apply for me if I work with kdelibs-3.5.5-r5 as a base: patching file kdeprint/cups/kmcupsmanager.h patching file kdeprint/cups/kmcupsuimanager.cpp patching file kdeprint/cups/kmcupsmanager.cpp Hunk #4 FAILED at 907. Hunk #5 succeeded at 959 with fuzz 2. 1 out of 7 hunks FAILED -- saving rejects to file kdeprint/cups/kmcupsmanager.cpp.rej patching file kdeprint/cups/cupsdoprint.c patching file kdeprint/kdeprintrc
you have to remove the previous cups patch.
is that wise? Are there things in the previous patch that need to stay in there? I admit, I don't use cups.
If you would not trust me, you could trust (erm... lol, I know) to kubuntu devs: http://packages.ubuntulinux.org/edgy/kde/kdelibs No, the previous patch didn't solve the problem and this one should at least get something working so, it is surely wise. The new patch add some new config lines to kdeprintrc to force default cups server to be "localhost" instead of the non-working-with-cups-1.2-(read-the-todo-list-of-kdelibs-for-cups-1.2) /var/run/cups/cups.sock management.
and btw, as far as I can see, it supports cups 1.1.x too.
I looked at the ubuntu patch but I cannot find the kdeprintrc part of them. Where exactly did you take your patch from? I find those cups related patches in the ubuntu diff http://archive.ubuntu.com/ubuntu/pool/main/k/kdelibs/kdelibs_3.5.5-0ubuntu3.diff.gz 12_cups_docroot.diff 13_cups_sysgroup.diff kubuntu_40_cups12_remove_async.diff kubuntu_41_cups12_startstopfix.diff kubuntu_42_cups12_addmodify.diff kubuntu_43_cups12_empty_printers.diff kubuntu_44_cups12_init_script.diff kubuntu_47_cups12_list_ignore_warnings.diff kubuntu_48_cups12_cupsdconf.diff kubuntu_55_printer_sharing.diff Which of those is it?
Hey guys, Could anybody please detail what's the correct procedure to apply the attached patch? I need to add a printer to KDE, and CUPS web interface is being a PITA... I'm willing to test it, but can't seem to apply it successfully...
I've no idea, why we have the patches included at all. The release announcement of KDE 3.5.5 claims it supports CUPS 1.2. Interestingly Ubuntu has the CUPS patches included in its 3.5.5 package, but not in the 3.5.6 one. And there have been no relevant fixes in kde.org svn in between the releases. Unless someone explains what I'm missing, I'm issuing a new kdelibs 3.5.6 tarball, removing the CUPS patches and targeting _slowly_ for 3.5.6 stabilization.
All I can say is that with KDE 3.5.6, CUPS works perfectly with kdeprint.
Arr, having tomatoes on my eyes. The patches have already been removed since a while.
