Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 154436 - app-portage/elogv enhancement
Summary: app-portage/elogv enhancement
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Other
: High enhancement (vote)
Assignee: Christian Faulhammer (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-11-08 01:21 UTC by Wolf Giesen (RETIRED)
Modified: 2006-11-10 02:20 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to elogv.py (elogv-bg.patch,11.61 KB, patch)
2006-11-08 01:21 UTC, Wolf Giesen (RETIRED)
Details | Diff
Cleaned up patch (elogv.py-pl2.patch,12.30 KB, patch)
2006-11-08 01:56 UTC, Wolf Giesen (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wolf Giesen (RETIRED) gentoo-dev 2006-11-08 01:21:20 UTC
Hi, I made a small patch to elogv for my convenience:

- added "normal" colorset to be able to change background color
- added background filling for upper and lower pane
- automatically display highlighted elog when app starts or highlight is moved
- changed "f" to "space" (easier to hit, only needed for scrolling long file now .-)

Maybe you're interested, otherwise I'll keep it local ^^

Regards,

Wolf
Comment 1 Wolf Giesen (RETIRED) gentoo-dev 2006-11-08 01:21:46 UTC
Created attachment 101431 [details, diff]
Patch to elogv.py
Comment 2 Wolf Giesen (RETIRED) gentoo-dev 2006-11-08 01:22:50 UTC
Oh, forgot ... made an ugly hack to give "Del" the "dd" functionality; this is definitely ugly, though (verbatim copy, he he).
Comment 3 Christian Faulhammer (RETIRED) gentoo-dev 2006-11-08 01:35:36 UTC
I am not upstream of this software, maybe you should contact him.  If there is no reaction, I think I can patch that software.
Comment 4 Wolf Giesen (RETIRED) gentoo-dev 2006-11-08 01:56:18 UTC
Ok, CCing. Excuse the spam (one more ...)
Comment 5 Wolf Giesen (RETIRED) gentoo-dev 2006-11-08 01:56:49 UTC
Created attachment 101434 [details, diff]
Cleaned up patch
Comment 6 Luca Marturana 2006-11-08 04:46:12 UTC
(In reply to comment #0)
> Hi, I made a small patch to elogv for my convenience:
> 
> - added "normal" colorset to be able to change background color
> - added background filling for upper and lower pane

I don't like much the white background. With the black background, colors like magenta, red and green are more readable.

> - automatically display highlighted elog when app starts or highlight is moved
> - changed "f" to "space" (easier to hit, only needed for scrolling long file
> now .-)

Good idea, I will apply this on the next release (0.5). Thanks

> 
> Maybe you're interested, otherwise I'll keep it local ^^
> 
> Regards,
> 
> Wolf
> 

Bye, Luca
Comment 7 Wolf Giesen (RETIRED) gentoo-dev 2006-11-08 05:40:23 UTC
(In reply to comment #6)

> I don't like much the white background. With the black background, colors like
> magenta, red and green are more readable.

True (going to modify colors a bit), but I didn' like the black. Anyway, it's just one more color pair you can easily change. Plus, it fills both boxes with the colors you select.
Comment 8 Wolf Giesen (RETIRED) gentoo-dev 2006-11-08 05:48:02 UTC
Hm, I just realized there's a little quirk: when running elogv under screen, it displays the background+border even when no files are present. It doesn't do that outside of screen. No clue as to why that is, you might want to look at it ^^.
Comment 9 Christian Faulhammer (RETIRED) gentoo-dev 2006-11-10 02:20:54 UTC
I close it then...