Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 154403 - Patch allowing revdep-rebuild to go on when one package doesn't build
Summary: Patch allowing revdep-rebuild to go on when one package doesn't build
Status: CONFIRMED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Tools (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Portage Tools Team
URL:
Whiteboard:
Keywords: Inclusion
: 163295 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-11-07 14:31 UTC by Denis Dupeyron (RETIRED)
Modified: 2023-05-10 08:36 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
The patch for revdep-rebuild (revdep-rebuild.patch,534 bytes, patch)
2006-11-07 14:32 UTC, Denis Dupeyron (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Denis Dupeyron (RETIRED) gentoo-dev 2006-11-07 14:31:12 UTC
When a package (from the list of packages to rebuild) doesn't build, revdep-rebuild stops rebuilding. It's a minor annoyance only, but still. When the list contains other packages with no common dependencies with the one(s) that doesn't build, it would be nice if revdep-rebuild went on and rebuilt as much as it can.

I don't know if this behavior is a feature or a bug, but in case it's a bug, the patch below is my solution to it. There probably is a zillion other ways to do it, though. Note that the following line:

echo "emerge --oneshot $EMERGE_OPTIONS $REBUILD_LIST"

which is about 15 lines above the beginning of my patch, may need to be adapted for mostly cosmetic reasons.

Denis.
Comment 1 Denis Dupeyron (RETIRED) gentoo-dev 2006-11-07 14:32:47 UTC
Created attachment 101415 [details, diff]
The patch for revdep-rebuild
Comment 2 Paul Varner (RETIRED) gentoo-dev 2007-01-23 00:08:41 UTC
*** Bug 163295 has been marked as a duplicate of this bug. ***
Comment 3 Pacho Ramos gentoo-dev 2007-01-23 19:50:43 UTC
Can you please, explain me how works this patch?

For example: I run revdep-rebuild and it re-emerges 50 apps, when it has compiled 20, compilation fails. 

What will do revdep-rebuild with your patch?

Thanks a lot for information :-)
Comment 4 Denis Dupeyron (RETIRED) gentoo-dev 2007-02-11 19:29:27 UTC
(In reply to comment #3)
> For example: I run revdep-rebuild and it re-emerges 50 apps, when it has
> compiled 20, compilation fails. 
> 
> What will do revdep-rebuild with your patch?

It will attempt to emerge each package individually, and if one fails it will skip to the next one. At the end of the process, if one package failed to emerge it will show a warning.

Denis.
Comment 5 Pacho Ramos gentoo-dev 2007-02-11 19:35:43 UTC
(In reply to comment #4)
> (In reply to comment #3)
> > For example: I run revdep-rebuild and it re-emerges 50 apps, when it has
> > compiled 20, compilation fails. 
> > 
> > What will do revdep-rebuild with your patch?
> 
> It will attempt to emerge each package individually, and if one fails it will
> skip to the next one. At the end of the process, if one package failed to
> emerge it will show a warning.
> 
> Denis.
> 

A really good behavior ;-)

Thanks for the patch
Comment 6 Paul Varner (RETIRED) gentoo-dev 2007-02-12 00:06:00 UTC
I plan on adding this patch within gentoolkit-0.2.3. I just need to find some time to test and play with it before it goes in.
Comment 7 Paul Varner (RETIRED) gentoo-dev 2007-03-09 04:27:42 UTC
This did not make it in to gentoolkit-0.2.3, I will look at it for gentoolkit-0.2.4
Comment 8 Bob's Your Uncle 2007-12-27 06:29:10 UTC
Won't simply running `emerge --resume --skipfirst` do the trick?
Comment 9 Pacho Ramos gentoo-dev 2023-05-10 08:36:40 UTC
This is probably now obsolete due to the --keep-going option in portage