Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 154193 - vlc-0.8.5-r5 compilation failed on cdda
Summary: vlc-0.8.5-r5 compilation failed on cdda
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: PPC Linux
: High normal (vote)
Assignee: Diego Elio Pettenò (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-11-05 15:24 UTC by François Bissey
Modified: 2006-11-10 16:20 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Modified patch file to fix some issues (230_all_libcdio-0.78.2.patch,3.62 KB, patch)
2006-11-07 05:06 UTC, Andre Hinrichs
Details | Diff
Modified patch file to fix some issues (230_all_libcdio-0.78.2.patch,3.62 KB, patch)
2006-11-07 05:28 UTC, Andre Hinrichs
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description François Bissey 2006-11-05 15:24:31 UTC
After doing an update over the week end I run revdep-rebuild. It prompted
a rebuild of vlc because of a library change. On emerging portage downloaded
a new patch set for vlc.
The compileation failed with the following message:
Making all in cdda
make[5]: Entering directory `/var/tmp/portage/vlc-0.8.5-r5/work/vlc-0.8.5/modules/access/cdda'
make[6]: Entering directory `/var/tmp/portage/vlc-0.8.5-r5/work/vlc-0.8.5/modules/access/cdda'
if powerpc-unknown-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I. -I../../..   -DSYS_LINUX -I../../../include `top_builddir="../../.." ../../../vlc-config --cflags plugin cddax` -Wsign-compare -Wall -O2 -mcpu=7450 -mtune=7450 -pipe -maltivec -mabi=altivec -fno-strict-aliasing -pipe -MT libcddax_plugin_a-access.o -MD -MP -MF ".deps/libcddax_plugin_a-access.Tpo" -c -o libcddax_plugin_a-access.o `test -f 'access.c' || echo './'`access.c; \
        then mv -f ".deps/libcddax_plugin_a-access.Tpo" ".deps/libcddax_plugin_a-access.Po"; else rm -f ".deps/libcddax_plugin_a-access.Tpo"; exit 1; fi
In file included from access.c:31:
cdda.h:76: error: expected identifier before numeric constant
make[6]: *** [libcddax_plugin_a-access.o] Error 1


====================
When I last emerged vlc-0.8.5-r5 on the 28th of September 2006 I had no problems.
Here is my emerge --info:
Portage 2.1.1-r1 (default-linux/ppc/ppc32/2006.1/G4, gcc-4.1.1, glibc-2.4-r3, 2.6.16-gentoo-r9 ppc)
=================================================================
System uname: 2.6.16-gentoo-r9 ppc 7450, altivec supported
Gentoo Base System version 1.12.6
Last Sync: Sun, 05 Nov 2006 21:50:01 +0000
ccache version 2.3 [enabled]
app-admin/eselect-compiler: [Not Present]
dev-java/java-config: 1.3.7, 2.0.30
dev-lang/python:     2.4.3-r4
dev-python/pycrypto: 2.0.1-r5
dev-util/ccache:     2.3
dev-util/confcache:  [Not Present]
sys-apps/sandbox:    1.2.17
sys-devel/autoconf:  2.13, 2.59-r7
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2
sys-devel/binutils:  2.17
sys-devel/gcc-config: 1.3.13-r4
sys-devel/libtool:   1.5.22
virtual/os-headers:  2.6.16
ACCEPT_KEYWORDS="ppc"
AUTOCLEAN="yes"
CBUILD="powerpc-unknown-linux-gnu"
CFLAGS="-O2 -mcpu=7450 -mtune=7450 -pipe -maltivec -mabi=altivec -fno-strict-aliasing"
CHOST="powerpc-unknown-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/share/X11/xkb /usr/share/config /usr/share/texmf/dvipdfm/config/ /usr/share/texmf/dvips/config/ /usr/share/texmf/tex/generic/config/ /usr/share/texmf/tex/platex/config/ /usr/share/texmf/xdvi/"
CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/gconf /etc/java-config/vms/ /etc/revdep-rebuild /etc/terminfo"
CXXFLAGS="-O2 -mcpu=7450 -mtune=7450 -pipe -maltivec -mabi=altivec -fno-strict-aliasing"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoconfig ccache distlocks metadata-transfer parallel-fetch sandbox sfperms strict"
GENTOO_MIRRORS="ftp://ftp.vic.keypoint.com.au http://mirrors.tds.net/gentoo ftp://mirrors.tds.net/gentoo http://mirror.tucdemonic.org/gentoo/"
LC_ALL="en_GB.UTF-8"
LDFLAGS="-Wl,--as-needed"
LINGUAS="fr en_GB"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --delete-after --stats --timeout=180 --exclude='/distfiles' --exclude='/local' --exclude='/packages'"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage /usr/portage/local/layman/science /usr/portage/local/layman/ebuild-exchange"
SYNC="rsync://rsync.au.gentoo.org/gentoo-portage"
USE="ppc X a52 aac aalib alsa altivec amr arts asf audiofile berkdb bitmap-fonts bonobo bzip2 cairo cddb cdf cdparanoia cdr cli cracklib crypt cups curl divx dlloader dri dts dv dvd dvdr dvdread elibc_glibc emboss encode esd expat f77 ffmepg fftw firefox flac foomaticdb fortran gdbm gif gmedia gmp gpm graphviz gs gstreamer gtk gtk2 gtkhtml hal iconv idn ieee1394 imagemagick imlib imlib2 input_devices_evdev input_devices_keyboard input_devices_mouse ipv6 isdnlog java jbig jpeg jpeg2k kde kdehiddenvisibility kdexdeltas kernel_linux lcms libg++ libwww linguas_en_GB linguas_fr live lzo mad mikmod mjpeg mng mp3 mp4 mpeg musepack musicbrainz ncurses netcdf network nls nptl nptlonly ogg openal openexr opengl oss pam pcre pdf perl png ppds pppd python qt3 qt4 quicktime rdesktop readline reflection ruby samba sdl session slang slp sndfile spell spl ssl svg szip tcl tcltk tcpd tetex theora tiff tk truetype truetype-fonts type1-fonts udev unicode usb userland_GNU vcd video_cards_fbdev video_cards_nv vorbis wmf wmp x264 xine xml xml2 xorg xv xvid zeroconf zlib"
Unset:  CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LANG, MAKEOPTS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 1 Per 2006-11-06 09:34:10 UTC
This happen on x86 as well:

make[6]: Entering directory `/var/tmp/portage/vlc-0.8.5-r5/work/vlc-0.8.5/modules/access/cdda'
if i686-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I. -I../../..   -DSYS_LINUX -I../../../include `top_builddir="../../.." ../../../vlc-config --cflags plugin cddax` -Wsign-compare -Wall -O2 -fomit-frame-pointer -march=i686 -pipe -pipe -MT libcddax_plugin_a-access.o -MD -MP -MF ".deps/libcddax_plugin_a-access.Tpo" -c -o libcddax_plugin_a-access.o `test -f 'access.c' || echo './'`access.c; \
	then mv -f ".deps/libcddax_plugin_a-access.Tpo" ".deps/libcddax_plugin_a-access.Po"; else rm -f ".deps/libcddax_plugin_a-access.Tpo"; exit 1; fi
if i686-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I. -I../../..   -DSYS_LINUX -I../../../include `top_builddir="../../.." ../../../vlc-config --cflags plugin cddax` -Wsign-compare -Wall -O2 -fomit-frame-pointer -march=i686 -pipe -pipe -MT libcddax_plugin_a-callback.o -MD -MP -MF ".deps/libcddax_plugin_a-callback.Tpo" -c -o libcddax_plugin_a-callback.o `test -f 'callback.c' || echo './'`callback.c; \
	then mv -f ".deps/libcddax_plugin_a-callback.Tpo" ".deps/libcddax_plugin_a-callback.Po"; else rm -f ".deps/libcddax_plugin_a-callback.Tpo"; exit 1; fi
In file included from callback.c:25:
cdda.h:76: error: syntax error before numeric constant

=============================================================

Here's *my* emerge --info:


Portage 2.1.1-r1 (default-linux/x86/2006.1/desktop, gcc-3.4.6, glibc-2.4-r3, 2.6.17-gentoo-r8 i686)
=================================================================
System uname: 2.6.17-gentoo-r8 i686 Intel(R) Pentium(R) M processor 1500MHz
Gentoo Base System version 1.12.6
Last Sync: Mon, 06 Nov 2006 12:50:01 +0000
app-admin/eselect-compiler: [Not Present]
dev-java/java-config: 1.3.7, 2.0.30
dev-lang/python:     2.4.3-r4
dev-python/pycrypto: 2.0.1-r5
dev-util/ccache:     [Not Present]
dev-util/confcache:  [Not Present]
sys-apps/sandbox:    1.2.17
sys-devel/autoconf:  2.13, 2.60
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2
sys-devel/binutils:  2.16.1-r3
sys-devel/gcc-config: 1.3.13-r4
sys-devel/libtool:   1.5.22
virtual/os-headers:  2.6.17-r1
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -fomit-frame-pointer -march=i686 -pipe"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/share/X11/xkb"
CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/gconf /etc/java-config/vms/ /etc/revdep-rebuild /etc/terminfo"
CXXFLAGS="-O2 -fomit-frame-pointer -march=i686 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoconfig distlocks metadata-transfer sandbox sfperms strict"
GENTOO_MIRRORS="http://ds.thn.htu.se/linux/gentoo http://distfiles.gentoo.org http://www.ibiblio.org/pub/Linux/distributions/gentoo"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --delete-after --stats --timeout=180 --exclude='/distfiles' --exclude='/local' --exclude='/packages'"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage"
USE="x86 X alsa arts berkdb bitmap-fonts cairo cdr cli cracklib crypt cups dlloader dri dvd eds elibc_glibc emboss encode esd fam firefox fortran gdbm gif gnome gpm gstreamer gtk hal howl iconv input_devices_keyboard input_devices_mouse ipv6 isdnlog jpeg kernel_linux libg++ mad mikmod motif mp3 mpeg ncurses nls nptl nptlonly ogg opengl oss pam pcre perl png ppds pppd python qt3 qt4 quicktime readline reflection sdl session spell spl ssl tcpd truetype truetype-fonts type1-fonts udev unicode userland_GNU video_cards_i810 video_cards_i830 video_cards_i915 vorbis win32codecs xml xorg xv zlib"
Unset:  CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LANG, LC_ALL, LDFLAGS, LINGUAS, PORTAGE_RSYNC_EXTRA_OPTS, PORTDIR_OVERLAY
Comment 2 Andre Hinrichs 2006-11-07 01:20:07 UTC
same here on x86

Portage 2.1.1-r1 (default-linux/x86/2006.1, gcc-4.1.1, glibc-2.4-r3, 2.6.17.13 i686)
=================================================================
System uname: 2.6.17.13 i686 Intel(R) Pentium(R) M processor 1.86GHz
Gentoo Base System version 1.12.6
Last Sync: Mon, 06 Nov 2006 23:20:01 +0000
distcc 2.18.3 i686-pc-linux-gnu (protocols 1 and 2) (default port 3632) [disabled]
app-admin/eselect-compiler: [Not Present]
dev-java/java-config: 1.3.7, 2.0.30
dev-lang/python:     2.4.3-r4
dev-python/pycrypto: 2.0.1-r5
dev-util/ccache:     [Not Present]
dev-util/confcache:  [Not Present]
sys-apps/sandbox:    1.2.17
sys-devel/autoconf:  2.13, 2.60
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2
sys-devel/binutils:  2.16.1-r3
sys-devel/gcc-config: 1.3.13-r4
sys-devel/libtool:   1.5.22
virtual/os-headers:  2.6.17-r1
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O3 -march=pentium3 -mfpmath=sse -mmmx -msse -maccumulate-outgoing-args -fomit-frame-pointer -pipe"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/share/X11/xkb /usr/share/config /usr/share/texmf/dvipdfm/config/ /usr/share/texmf/dvips/config/ /usr/share/texmf/tex/generic/config/ /usr/share/texmf/tex/platex/config/ /usr/share/texmf/xdvi/"
CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/gconf /etc/java-config/vms/ /etc/revdep-rebuild /etc/terminfo"
CXXFLAGS="-O3 -march=pentium3 -mfpmath=sse -mmmx -msse -maccumulate-outgoing-args -fomit-frame-pointer -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoconfig distlocks metadata-transfer sandbox sfperms strict"
GENTOO_MIRRORS="http://192.168.178.22/ http://192.168.178.23/ http://pandemonium.tiscali.de/pub/gentoo/ http://gentoo.intergenia.de http://mirror.switch.ch/ftp/mirror/gentoo/ http://ftp.du.se/pub/os/gentoo"
LANG="de_DE.UTF-8"
LC_ALL="de_DE.UTF-8"
LINGUAS="de en en_US en_GB es"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --delete-after --stats --timeout=180 --exclude='/distfiles' --exclude='/local' --exclude='/packages'"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage /usr/portage/local/layman/pro-audio"
SYNC="rsync://rsync.de.gentoo.org/gentoo-portage"
USE="x86 X a52 aac accessibility acl acpi alsa apache2 arts audiofile berkdb bidi big-tables binfilter bitmap-fonts browserplugin bzip2 cairo cdda cddb cdparanoia chroot cjk cli corba cracklib crypt cups curl daap dlloader dri dts dv dvb dvd dvdread eds elibc_glibc emacs encode exif expat fame flac foomaticdb fortran gd gdbm gif gimp gmp gnutls gpm gs gstreamer gtk guile guionly hpn iconv idn ieee1394 imagemagick imlib input_devices_keyboard input_devices_mouse isdnlog java jbig jpeg junit kde kdeenablefinal kernel_linux lcms ldap leim libg++ linguas_de linguas_en linguas_en_GB linguas_en_US linguas_es live lua lzo mad mailwrapper matroska mikmod mjpeg mmx mng mod motif mozilla moznocompose moznoirc moznomail mp3 mpeg mysql ncurses network nls nptl nptlonly nsplugin objc ocaml odbc ogg openal openexr opengl pam pcre pdf perl php png povray ppds pppd python qt3 qt4 quicktime readline real reflection rle rtc rtsp sasl scanner sdl session shout slp sndfile speex spell spl sse ssl stream subtitles subversion svg svga tcltk tcpd tetex theora threads tidy tiff timidity tk truetype truetype-fonts type1-fonts ucs2 udev unicode usb userland_GNU v4l v4l2 vcd video_cards_fglrx video_cards_vesa vlm vorbis win32codecs wmf wxwindows xanim xml xorg xosd xscreensaver xv xvid yv12 zlib"
Unset:  CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LDFLAGS, MAKEOPTS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 3 Andre Hinrichs 2006-11-07 05:06:46 UTC
Created attachment 101388 [details, diff]
Modified patch file to fix some issues

I did some investigation on this and found that the version number in line 74 of cdda.h must be 72 not 78!
I downloaded versions of libcdio from 0.70 to 0.78 unpacked them and checked for PARANOIA_MODE_FULL with the following command and result:

# find -type f -name paranoia.h -exec grep -l PARANOIA_MODE {} \;
./libcdio-0.72/include/cdio/paranoia.h
./libcdio-0.73/include/cdio/paranoia.h
./libcdio-0.74/include/cdio/paranoia.h
./libcdio-0.75/include/cdio/paranoia.h
./libcdio-0.76/include/cdio/paranoia.h
./libcdio-0.77/include/cdio/paranoia.h
./libcdio-0.78/include/cdio/paranoia.h

Looking into ./libcdio-0.72/include/cdio/paranoia.h showed that all necessary defines are there.

So, that was easy to fix...

...but... more errors occured afterwards...
More investigations showed that more version checks seemed to be wrong.

Finally I changed version checks on six locations.

The patch is a replacement of the patchfile in the patchset.
vlc at least compiled fine on my system with this patch. Checking with a avi file worked. More tests need to be done...
Comment 4 Andre Hinrichs 2006-11-07 05:28:55 UTC
Created attachment 101390 [details, diff]
Modified patch file to fix some issues

I did some investigation on this and found that the version number in line 74 of cdda.h must be 72 not 78!
I downloaded versions of libcdio from 0.70 to 0.78 unpacked them and checked for PARANOIA_MODE_FULL with the following command and result:

# find -type f -name paranoia.h -exec grep -l PARANOIA_MODE {} \;
./libcdio-0.72/include/cdio/paranoia.h
./libcdio-0.73/include/cdio/paranoia.h
./libcdio-0.74/include/cdio/paranoia.h
./libcdio-0.75/include/cdio/paranoia.h
./libcdio-0.76/include/cdio/paranoia.h
./libcdio-0.77/include/cdio/paranoia.h
./libcdio-0.78/include/cdio/paranoia.h

Looking into ./libcdio-0.72/include/cdio/paranoia.h showed that all necessary defines are there.

So, that was easy to fix...

...but... more errors occured afterwards...
More investigations showed that more version checks seemed to be wrong.

Finally I changed version checks on six locations.

The patch is a replacement of the patchfile in the patchset.
vlc at least compiled fine on my system with this patch. Checking with a avi file worked. More tests need to be done...
Comment 5 François Bissey 2006-11-09 18:15:25 UTC
I just tried the patch. It install and works here on ppc.
Cheers.
Comment 6 Thomas Pani 2006-11-10 11:08:44 UTC
vlc-patches >= 28 come w/ a patch of for libcdio-0.78.2. Thus vlc having a PATCHLEVEL >= 28 (currently vlc-0.8.5-r5) should have a dependency on >=dev-libs/libcdio-0.78.2.

You should not re-patch your cdda.{c|h}; rather unmask libcdio! (this is working for me on x86).
Comment 7 Diego Elio Pettenò (RETIRED) gentoo-dev 2006-11-10 16:20:11 UTC
Should be fixed now.