Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 153227 - subversion.eclass and peg revisions
Summary: subversion.eclass and peg revisions
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: High normal
Assignee: Akinori Hattori
URL:
Whiteboard:
Keywords:
: 169013 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-10-28 20:38 UTC by David Li
Modified: 2007-04-01 14:50 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to make peg revisions work (subersion.eclass.patch,908 bytes, patch)
2006-10-28 20:39 UTC, David Li
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Li 2006-10-28 20:38:13 UTC
Getting a operative revision can be done by ESVN_OPTIONS="-r number". Getting a peg revision is done by setting ESVN_REPO_URI="svn://...../blah@number"

However, this messes up $wc_path in subversion.eclass.

See:
http://svnbook.red-bean.com/nightly/en/svn.advanced.pegrevs.html
Comment 1 David Li 2006-10-28 20:39:07 UTC
Created attachment 100684 [details, diff]
Patch to make peg revisions work

This is an example of a patch that would make peg revisions work. However, it's a bit of a hack IMO.
Comment 2 Akinori Hattori gentoo-dev 2007-01-19 10:40:54 UTC
Fixed in CVS. Thank you for reporting!
Comment 3 Jakub Moc (RETIRED) gentoo-dev 2007-03-02 20:25:05 UTC
*** Bug 169013 has been marked as a duplicate of this bug. ***
Comment 4 Jakub Moc (RETIRED) gentoo-dev 2007-03-02 20:25:32 UTC
People complain that the fix is broken; see Bug 169013 
Comment 5 David Li 2007-03-03 02:12:31 UTC
I see that the maintainer has improved my original patch a lot. However, the general gist is that the substitution expression needs to be tightened up.

Maybe regex like @[^/]* would be work better. However doesn't handle when there is no path, like blah://user@server. Adding a trailing /, like blah://user@server/, would work though.

Now if only bash supported regex's everywhere.
Comment 6 Akinori Hattori gentoo-dev 2007-04-01 14:50:16 UTC
May be fixes bug 169013 at rev 1.41.