Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 152809 - patch disabling ratio checking in mldonkey-2.8.1
Summary: patch disabling ratio checking in mldonkey-2.8.1
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Other
: High enhancement
Assignee: Gentoo net-p2p team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-10-25 12:58 UTC by Hubert Mercier (RETIRED)
Modified: 2007-02-05 23:05 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
mldonkey-2.8.1 ebuild, including "noratio" patch (mldonkey-2.8.1.ebuild,4.31 KB, application/octet-stream)
2006-10-25 12:59 UTC, Hubert Mercier (RETIRED)
Details
mldonkey-2.8.1-noratio patch (mldonkey-2.8.1-noratio.patch,473 bytes, patch)
2006-10-25 12:59 UTC, Hubert Mercier (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hubert Mercier (RETIRED) gentoo-dev 2006-10-25 12:58:18 UTC
Hi,

Recently I upgraded my ~amd64 system, and ran into bug #148087. I followed the instructions of the bug report, and installed mldonkey-2.8.1. Everything is ok with that, but a minor "problem". This new release of the daemon introduces a "ul/dl ratio check".

And this is really a problem to me, since I work in a quite "secure" environment, only my workstation is allowed to use p2p applications, and I must reduce as much as possible my upload. I won't give you more details, since I'm just not granted the right to. But, the fact is : I can't use mldonkey anymore with this ratio check, since it limits my download rate drastically (3 kb/s), and becomes useless.

So, I made a little patch, introducing a "noratio" USE flag for this app. But before submitting it publicly, I thought it may be discussed internally, since this patch may go against mldonkey's developer team wishes, or just against p2p spirit / philosophy ? In fact, I didn't know if this was a good idea or not. In my case, no choice : I _must_ use it.

Feel free to comment,

Cheers,
Comment 1 Hubert Mercier (RETIRED) gentoo-dev 2006-10-25 12:59:21 UTC
Created attachment 100480 [details]
mldonkey-2.8.1 ebuild, including "noratio" patch
Comment 2 Hubert Mercier (RETIRED) gentoo-dev 2006-10-25 12:59:59 UTC
Created attachment 100481 [details, diff]
mldonkey-2.8.1-noratio patch
Comment 3 Raúl Porcel (RETIRED) gentoo-dev 2007-01-10 09:50:05 UTC
No, this can't be added to the tree. You are modifying the behaviour of the package. I don't think disabling the ratio checking is optional. If it was added in this version, it's because it was needed.
Comment 4 Hubert Mercier (RETIRED) gentoo-dev 2007-01-11 20:14:35 UTC
Thanks for the input.

Well, in fact I'm not modifying the behaviour of the software (mldonkey wasn't part of the "ranking" system before v2.8.0.). I'm just restoring the behaviour to the older version. But anyway, I understand that allowing to break this limitation may be a pain for the developpers, who were probably asked to do that. I'll just keep this patch private then.

Cheers,
Comment 5 Raúl Porcel (RETIRED) gentoo-dev 2007-01-11 22:28:21 UTC
(In reply to comment #4)
> Thanks for the input.
> 
> Well, in fact I'm not modifying the behaviour of the software (mldonkey wasn't
> part of the "ranking" system before v2.8.0.). I'm just restoring the behaviour
> to the older version. But anyway, I understand that allowing to break this
> limitation may be a pain for the developpers, who were probably asked to do
> that. I'll just keep this patch private then.
> 
> Cheers,
> 
I don't think this a new feature in 2.8.0. It was just a bug. Maybe you don't know, but if you leech, that is, breaking the ratio thing, you are banned by the peer.

The ratio check can't be disabled...it's not optional. All clients should check the ratio.