Hi, Recently I upgraded my ~amd64 system, and ran into bug #148087. I followed the instructions of the bug report, and installed mldonkey-2.8.1. Everything is ok with that, but a minor "problem". This new release of the daemon introduces a "ul/dl ratio check". And this is really a problem to me, since I work in a quite "secure" environment, only my workstation is allowed to use p2p applications, and I must reduce as much as possible my upload. I won't give you more details, since I'm just not granted the right to. But, the fact is : I can't use mldonkey anymore with this ratio check, since it limits my download rate drastically (3 kb/s), and becomes useless. So, I made a little patch, introducing a "noratio" USE flag for this app. But before submitting it publicly, I thought it may be discussed internally, since this patch may go against mldonkey's developer team wishes, or just against p2p spirit / philosophy ? In fact, I didn't know if this was a good idea or not. In my case, no choice : I _must_ use it. Feel free to comment, Cheers,
Created attachment 100480 [details] mldonkey-2.8.1 ebuild, including "noratio" patch
Created attachment 100481 [details, diff] mldonkey-2.8.1-noratio patch
No, this can't be added to the tree. You are modifying the behaviour of the package. I don't think disabling the ratio checking is optional. If it was added in this version, it's because it was needed.
Thanks for the input. Well, in fact I'm not modifying the behaviour of the software (mldonkey wasn't part of the "ranking" system before v2.8.0.). I'm just restoring the behaviour to the older version. But anyway, I understand that allowing to break this limitation may be a pain for the developpers, who were probably asked to do that. I'll just keep this patch private then. Cheers,
(In reply to comment #4) > Thanks for the input. > > Well, in fact I'm not modifying the behaviour of the software (mldonkey wasn't > part of the "ranking" system before v2.8.0.). I'm just restoring the behaviour > to the older version. But anyway, I understand that allowing to break this > limitation may be a pain for the developpers, who were probably asked to do > that. I'll just keep this patch private then. > > Cheers, > I don't think this a new feature in 2.8.0. It was just a bug. Maybe you don't know, but if you leech, that is, breaking the ratio thing, you are banned by the peer. The ratio check can't be disabled...it's not optional. All clients should check the ratio.