Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 152718 - media-libs/faac-1.25 version bump request
Summary: media-libs/faac-1.25 version bump request
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-10-24 16:47 UTC by Tim Harder
Modified: 2007-03-17 20:07 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
faac-1.25.ebuild (faac-1.25.ebuild,885 bytes, text/plain)
2006-10-24 18:42 UTC, Tim Harder
Details
ebuild for faac 1.2.5 that fixes aclocal problems (faac-1.25.ebuild,926 bytes, text/plain)
2006-11-22 04:19 UTC, Christian Schmidt
Details
Re-enable support for external libmp4v2 (faac-1.25-external-libmp4v2.patch,2.12 KB, patch)
2006-11-22 08:18 UTC, Christian Schmidt
Details | Diff
Updated ebuild for faac 1.25 (faac-1.25.ebuild,976 bytes, text/plain)
2006-11-22 08:20 UTC, Christian Schmidt
Details
faac-1.25 with recode deps (faac-1.25.ebuild,993 bytes, text/plain)
2007-02-06 23:27 UTC, stephan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Harder gentoo-dev 2006-10-24 16:47:15 UTC
After looking through the source code, it appears that the as-needed patch was incorporated into this release. Also, the tracknumber patch used with the previous version is probably not necessary anymore as the faac team changed the problematic code to use another scanf parameter that doesn't consider numbers starting with 0 as octal.
Comment 1 Tim Harder gentoo-dev 2006-10-24 17:14:05 UTC
I forgot to mention that the automake process failed for me on the upstream package due to some EOL problems with configure.in as it has both CR and LF. Changing all EOL to LF only and repackaging solved the problem.
Comment 2 Tim Harder gentoo-dev 2006-10-24 18:42:20 UTC
Created attachment 100433 [details]
faac-1.25.ebuild

The ebuild is almost a direct bump of the previous version except it doesn't contain the epatch lines.
Comment 3 Christian Schmidt 2006-11-22 04:19:28 UTC
Created attachment 102537 [details]
ebuild for faac 1.2.5 that fixes aclocal problems

The configure.in in the toplevel directory is saved with CRLF linebreaks, which somehow doesn't work with my aclocal. Added a recode for this.
Comment 4 Christian Schmidt 2006-11-22 08:18:57 UTC
Created attachment 102552 [details, diff]
Re-enable support for external libmp4v2

If libmp4v2 is installed, support for mp4 is completely lost in faac 1.25. This patch changes a bit of the automake/autoconf input to re-enable it.
Comment 5 Christian Schmidt 2006-11-22 08:20:26 UTC
Created attachment 102553 [details]
Updated ebuild for faac 1.25

This ebuild applies the mp4 re-enable patch, and fixes a CRLF conversion problem that stops aclocal to parse the configure.in.
Comment 6 stephan 2006-12-18 14:16:33 UTC
the ebuild for 1.25 by christian works for me and faac won't "freeze" any more :o)
Comment 7 Diego Elio Pettenò (RETIRED) gentoo-dev 2006-12-22 01:03:39 UTC
Did anybody check if the license is still GPL or they changed it like for faad?
Comment 8 stephan 2007-02-06 23:27:45 UTC
Created attachment 109394 [details]
faac-1.25 with recode deps

I've incldued app-text/recode in deps since it is not present in default stage3
Comment 9 Ben de Groot (RETIRED) gentoo-dev 2007-02-18 17:31:35 UTC
The license is still LGPL-2. I added stephan's ebuild to the berkano overlay (see http://forums.gentoo.org/viewtopic-t-508174.html ).
Comment 10 Steve Dibb (RETIRED) gentoo-dev 2007-03-17 20:07:07 UTC
thanks for the ebuilds and patches, guys. committed to cvs