Ebuilds in portage for media-plugins/mythdvd and mythvideo currently list mplayer, xine-ui, and ogle as hard dependencies, but are optional with the use of myth's internal player. Please consider making these a bit more optional- I've included diffs of the changes I've been using the past few days below, along with including a vcd flag that gone unused as noted by beandog. I've only done very limited testing with these so far, I'll post updates if I run accross issues. Since myth's internal player is problematic for many DVD's it still makes sense to have an external player enabled by default, but I prefer the consistent interface of the internal player since it works for the DVD's I'm using. Also, upstream has removed XML-Simple as a dependency for mythvideo as of rev 10855 (http://svn.mythtv.org/trac/changeset/10855), so I've removed that line as well. --- /usr/portage/media-plugins/mythdvd/mythdvd-0.20_p11329.ebuild 2006-09-29 07:30:37.000000000 -0700 +++ mythdvd-0.20_p11329-r3.ebuild 2006-10-22 20:11:57.000000000 -0700 @@ -6,14 +6,20 @@ DESCRIPTION="DVD player module for MythTV." KEYWORDS="~amd64 ~ppc ~x86" -IUSE="transcode" +IUSE="transcode internal vcd" RDEPEND="=media-plugins/mythvideo-${MY_PV}* transcode? ( media-video/transcode media-libs/libdvdread ) - || ( media-video/mplayer media-video/xine-ui media-video/ogle )" + !internal? ( + || ( + media-video/mplayer + media-video/xine-ui + media-video/ogle + ) + )" -MTVCONF="--enable-vcd $(use_enable transcode)" +MTVCONF="$(use_enable vcd) $(use_enable transcode)" src_install() { mythtv-plugins_src_install @@ -22,6 +28,14 @@ } pkg_postinst() { + + if use internal; then + echo + einfo "Please note that the Internal video player may not be compatible" + einfo "with all DVDs. See the mythdvd readme for more information." + + fi + echo einfo "To have Myth Transcode Daemon (mtd) start on boot do the following" einfo "rc-update add mtd default" --- /usr/portage/media-plugins/mythvideo/mythvideo-0.20_p11329.ebuild 2006-10-05 19:43:57.000000000 -0700 +++ mythvideo-0.20_p11329-r2.ebuild 2006-10-22 20:33:44.000000000 -0700 @@ -5,12 +5,32 @@ inherit mythtv-plugins DESCRIPTION="Video player module for MythTV." -IUSE="" +IUSE="internal" KEYWORDS="~amd64 ~ppc ~x86" +# http://svn.mythtv.org/trac/changeset/10855 +# + RDEPEND="dev-perl/libwww-perl dev-perl/HTML-Parser dev-perl/URI - dev-perl/XML-Simple - || ( media-video/mplayer media-video/xine-ui )" + !internal ( + || ( + media-video/mplayer + media-video/xine-ui + media-video/ogle + ) + )" + DEPEND="${RDEPEND}" + +pkg_postinst() { + + if use internal; then + echo + einfo "Please note that the Internal video player may not be compatible" + einfo "with all DVDs. See the mythdvd readme for more information." + + fi +}
Created attachment 100245 [details, diff] USE flags update for media-plugins/mythdvd
Created attachment 100246 [details, diff] USE flag and dependency update for media-plugins/mythvideo
Please, don't inline patches into bugs, use attachments.
This is already done for MythVideo. Steve: You think we should pull out any sort of depends in mythdvd, since they'll get pulled in by mythvideo? If not, then just copy your stuff from mythvideo?
(In reply to comment #4) > This is already done for MythVideo. > > Steve: You think we should pull out any sort of depends in mythdvd, since > they'll get pulled in by mythvideo? If not, then just copy your stuff from > mythvideo? > No, I think it's safe to let MythVideo do the USE flag selecting.
Also, I dont want to start adding USE flags for every possible media player out there. Since mplayer and xine are already in the tree, we can utilize those for convenience, but no need to add ogle, vlc, gxine, totem, etc. A 'vcd' USE flag would be okay though.
Fixed
