Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 152280 - xorg-server dga use flag
Summary: xorg-server dga use flag
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Other
: High enhancement
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-10-21 11:24 UTC by Kaiting Chen
Modified: 2007-09-30 19:56 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kaiting Chen 2006-10-21 11:24:37 UTC
There's a couple use flags "dga" and "xinerama" specifically, which are listed in use.desc and should probably be used by xorg-server.

For example, xorg-server right now automatically installs support for dga and xinerama, and pulls in their respective libraries and protocols as dependencies.

To fix, make "x11-proto/xf86dgaproto" depend on the "dga" flag and "x11-proto/xineramaproto" depend on the "xinerama" flag.
Comment 1 Jakub Moc (RETIRED) gentoo-dev 2006-10-21 11:28:49 UTC
We won't be adding xinerama use flag, see the other bug.


*** This bug has been marked as a duplicate of 124428 ***
Comment 2 Kaiting Chen 2006-10-21 12:04:58 UTC
Fair enough. But how about the "dga" flag. That's kind of a security concern too.
Comment 3 Jakub Moc (RETIRED) gentoo-dev 2006-10-21 12:14:32 UTC
(In reply to comment #2)
> That's kind of a security concern too.

??? o_O

Comment 4 Kaiting Chen 2006-10-21 12:23:20 UTC
Well, okay, it's not a huge security concern because you have to be root to even use it, but anything that exposes a chunk of memory and says "go at it" can be security-problematic.
Plus if you search around you see that xfree86-dga does have a bunch of security holes filed against it.
Comment 5 Donnie Berkholz (RETIRED) gentoo-dev 2006-10-21 22:33:47 UTC
Feel free to disable it in xorg.conf if you do not want to use it. There is no flag to not build support for it at all in the upstream sources, and I'm not really interested in adding one. If you wish, you may submit a patch upstream (bugs.freedesktop.org, Xorg product) to do so and then use EXTRA_ECONF to pass in your new option to the ebuild.
Comment 6 Kaiting Chen 2006-10-22 11:32:14 UTC
Actually. There is.
Sorry if.

Just add $(use_enable dga) to the configure line. xorg-server has a --enable/disable-dga flag that can be passed to the configure script.
And make the xf86dgaproto dependency depend on the dga flag.

That's really all you have to do.
Comment 7 Donnie Berkholz (RETIRED) gentoo-dev 2006-10-22 21:07:44 UTC
You are right; there is a (likely never tested) option to disable it. I say it's probably never been tested because it doesn't actually make the xf86dgaproto dep optional and doesn't actually disable dga. Numerous source files include headers from xf86dgaproto even with it disabled:

hw/xfree86/common/xf86DGA.c
hw/xfree86/common/xf86cmap.c
hw/xfree86/dixmods/extmod/modinit.h
hw/xfree86/vgahw/vgaCmap.c

In configure.ac, this is unconditionally defined:
AC_DEFINE(XFreeXDGA, 1, [Build XDGA support])

But a number of files still aren't fixed, even when that is changed.

This hasn't given me any more interest in adding the flag.
Comment 8 Jakub Moc (RETIRED) gentoo-dev 2007-09-30 19:56:04 UTC
Don't see why is this still open, no point in adding useless use flags.