Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 152278 - app-xemacs/xemacs-ispell:should depend on app-text/ispell
Summary: app-xemacs/xemacs-ispell:should depend on app-text/ispell
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal
Assignee: XEmacs team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-10-21 11:08 UTC by Chris Kerr
Modified: 2009-05-31 21:38 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Kerr 2006-10-21 11:08:49 UTC
from xemacs-ispell-1.24.ebuild, line 14 :
DEPEND=""

it should be

DEPEND="app-text/ispell"

I presume the 'inherit xemacs-packages' means that it depends on app-editors/xemacs, but if someone has missed out ispell then I might as well check for this too.


GNU emacs also uses ispell, so this should be added to its dependencies (possibly with a USE flag)
Comment 1 Hans de Graaff gentoo-dev Security 2006-10-22 01:31:10 UTC
I don't think that this is the right solution, as ispell.el does not depend on having app-text/ispell installed. For example, I'm using aspell just fine instead. 

Perhaps a better solution would be to depend on a virtual/spell (but this currently does not exist) or to indicate in the ebuild output that an external spelling application is needed to actually perform spelling.
Comment 2 Josh Glover (RETIRED) gentoo-dev 2007-06-20 01:47:46 UTC
I'd like to see this fixed, so I'm re-opening and assiging to myself.
Comment 3 Josh Glover (RETIRED) gentoo-dev 2007-06-20 01:49:37 UTC
My battle plan is:

1. See if I can do a logical or in DEPEND, i.e.
   DEPEND="app-text/ispell || app-text/aspell"
2. Failing that, implement virtual/spell
Comment 4 Hans de Graaff gentoo-dev Security 2007-06-20 05:58:35 UTC
Battle plan sounds good to me. One additional concern I have is that this should probably be covered by the 'spell' USE flag. This may sound funny, but there are a lot of xemacs interdependencies and it is possible that users may have to install xemacs-ispell even if they don't want to have any spelling capability. In fact, given that xemacs-devel depends on this means that this is true for the majority of users. Always installing external software on top of that, even if the user doesn't care about spelling, doesn't seem right.

Also, this should be covered by RDEPEND, not DEPEND.
Comment 5 Łukasz Damentko (RETIRED) gentoo-dev 2008-03-14 17:42:25 UTC
Reassigning to herd since jmglov has retired from Gentoo.
Comment 6 Hans de Graaff gentoo-dev Security 2009-05-31 21:38:07 UTC
After discussing this with the emacs herd, and following the discussion in bug 72850 we won't be implementing such a USE flag after all.