I've updated the ebuild to check for pcre, session, and mysql support in PHP (all of which are required) and have also added the ~amd64 keyword. Other possible ebuild improvements for the future: * patch install.php to give default paths for bibutils and mysql (though refbase-0.9.0 will already have this functionaliyu) * automate the sql installation so that install.php doesn't need to be used. * add unicode USE flag and, if present, check that php was installed with unicode support.
Created attachment 99957 [details] refbase ebuild modified with ~amd64 and with check for php USE
Comment on attachment 99957 [details] refbase ebuild modified with ~amd64 and with check for php USE Missing inherit there...
Created attachment 99958 [details] ebuild with fixed inherit and header Thanks. The header was also screwed up.
Created attachment 99959 [details, diff] ignore this one proper fix for the ebuild - fix (R)DEPEND (nothing should depend on webapp-config directly, the rest are RDEPENDS only, use need_php instead) - check for all needed php use flags at once, run webapp_pkg_setup as well, otherwise the ebuild will fail - do not install COPYING and INSTALL in dodoc
Nice fix. Is there any reason not to have the "~amd64" keyword? It appears that the ebuild of app-text/bibutils that is in portage is missing it too, but the ebuild which was in bugzilla had it & bibutils also works on amd64.
I don't have an amd64, so I can't keyword it.
Why do the PHPCHECKNODIE="yes" when you repeat the same message the eclass uses?
(In reply to comment #7) > Why do the PHPCHECKNODIE="yes" when you repeat the same message the eclass > uses? So that the ebuild doesn't die 3 times if the user has none of the flags set for PHP? Feel free to suggest a better solution... (On a side note, why does this even RDEPEND on mysql unconditionally? Can't use remote DB, or?)
(In reply to comment #8) > (In reply to comment #7) > > Why do the PHPCHECKNODIE="yes" when you repeat the same message the eclass > > uses? > > So that the ebuild doesn't die 3 times if the user has none of the flags set > for PHP? Feel free to suggest a better solution... 3 times? How can something die 3 times? The implementation of require_php_with_use() doesn't look like it would die 3 times (although I'm unsure what that means). > (On a side note, why does this even RDEPEND on mysql unconditionally? Can't use > remote DB, or?) That's a rare use case, imho, and not worth considering unless you have a clean way to do it that's already in use elsewhere (I know this isn't the only webapp that uses a DB).
Created attachment 99970 [details, diff] ignore this one (In reply to comment #9) > The implementation of require_php_with_use() doesn't look like it would die 3 > times (although I'm unsure what that means). Sigh, because I've attached wrong version of the patch. Read the one attached above. Can't do that otherwise with the eclass if you want to avoid potentially dying repeatedly. > > (On a side note, why does this even RDEPEND on mysql unconditionally? Can't use > > remote DB, or?) > > That's a rare use case, imho, and not worth considering unless you have a clean > way to do it that's already in use elsewhere (I know this isn't the only webapp > that uses a DB). mysql? ( >=dev-db/mysql-4.1 ) See http://www.gentoo.org/proj/en/webapps/webapp-eclass.xml. This only needs support for MySQL in PHP, the DB can be anywhere else so there's not much point in forcing it on users.
Created attachment 99971 [details, diff] refbase-0.8.0-r1.ebuild.diff (now) Urgh, not my day with attachments really.
The patched ebuild worksforme on amd64 and x86. Also: refbase-0.9.0 has been released & the ebuild works when version bumped.
Slight variation on #99959 is the way to go, minus the NODIE stuff. Discussed this w Jakub on IRC after noting that refbase supports php-mysql only, not mysqli.
<snip> -require_php_with_use mysql +require_php_with_use mysql pcre session </snip> for the current ebuild... anyone? getting really stale.
Thanks much for the reminder! I just added the additional checks and bumped to refbase-0.9.0. cheers, Markus
