Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 151643 - Suggested improvements/fixes to games-kids/gcompris-8.1
Summary: Suggested improvements/fixes to games-kids/gcompris-8.1
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All Linux
: High normal
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2006-10-16 15:14 UTC by Denis Dupeyron (RETIRED)
Modified: 2006-11-06 18:47 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
gcompris-8.1.ebuild (gcompris-8.1.ebuild,1.17 KB, text/plain)
2006-10-16 15:15 UTC, Denis Dupeyron (RETIRED)
Details
gcompris-8.1.ebuild.diff (gcompris-8.1.ebuild.diff,1.55 KB, patch)
2006-10-31 13:30 UTC, Denis Dupeyron (RETIRED)
Details | Diff
gcompris-8.1.ebuild.diff (gcompris-8.1.ebuild.diff,1.57 KB, patch)
2006-10-31 14:10 UTC, Denis Dupeyron (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Denis Dupeyron (RETIRED) gentoo-dev 2006-10-16 15:14:12 UTC
gcompris-8.1 was just released. Please find below an ebuild for it.

I have cleaned-up the dependencies (some were added, some simplified, some implicit/unneeded were removed). Also, since so many activities now use python, since gnome-python isn't needed any more, and since python is in the base profile anyway, I thought it made little sense to keep the python USE flag.

Denis.
Comment 1 Denis Dupeyron (RETIRED) gentoo-dev 2006-10-16 15:15:56 UTC
Created attachment 99835 [details]
gcompris-8.1.ebuild

The ebuild.
Comment 2 Mr. Bones. (RETIRED) gentoo-dev 2006-10-16 15:26:14 UTC
Please file a new bug that improves the 8.1 ebuild already in portage.  Thanks.
Comment 3 Denis Dupeyron (RETIRED) gentoo-dev 2006-10-31 13:29:04 UTC
As promised on irc, here's the list of the improvements and fixes I suggest for gcompris-8.1.

New required dependencies :
* media-gfx/tuxpaint
* sci-electronics/gnucap

Should be in RDEPEND but not in DEPEND :
* gnuchess
* tuxpaint
* gnucap

Not needed :
* inherit eutils
* dev-python/gnome-python

About python, I would drop the USE flag and make it a mandatory dependency. here's why :
* A lot of popular activities are now using python
* python is in the base profile
* there's always the objection of the number of additional dependencies, but gcompris is already more than 80 megs itself (not counting the mandatory dependencies)
* as far as I remember, python was made optional at some point mainly because it was problematic, which doesn't seem to be the case anymore

There is also now support for gnet, but Bruno Coudoin himself says it's rather useless at this time. So I'd wait for future versions before adding it.
Comment 4 Denis Dupeyron (RETIRED) gentoo-dev 2006-10-31 13:30:47 UTC
Created attachment 100918 [details, diff]
gcompris-8.1.ebuild.diff

A patch against the current ebuild implementing the suggestions above.
Comment 5 Tristan Heaven (RETIRED) gentoo-dev 2006-10-31 13:37:31 UTC
There were some changes made to the ebuild yesterday.
Comment 6 Denis Dupeyron (RETIRED) gentoo-dev 2006-10-31 14:10:32 UTC
Created attachment 100920 [details, diff]
gcompris-8.1.ebuild.diff

(In reply to comment #5)
> There were some changes made to the ebuild yesterday.

Sorry, I always feel like I sync'ed 5 minutes ago, but apparently not. The suggestions are still valid, though. The patch needed a bit of fixing, so here it is again.
Comment 7 Mr. Bones. (RETIRED) gentoo-dev 2006-10-31 14:17:12 UTC
No, forcing python on isn't an improvement.  Not going to accept that part of the patch.  the eutils change is good.  take gnuchess out of the second RDEPEND, it's required to build so it's already in the first one.
Comment 8 Mr. Bones. (RETIRED) gentoo-dev 2006-11-06 18:47:28 UTC
Well, I added the two additional rdeps you mentioned for 8.2.  Since I don't want to force the python deps on eveyone, I think this is as fixed as it's going to get.  Any patch for 8.2 should go in a new bug.  Thanks.