151640 – games-engines/exult-1.2 has superfluous asm USE flags

Bug 151640 - games-engines/exult-1.2 has superfluous asm USE flags

Summary: games-engines/exult-1.2 has superfluous asm USE flags

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] Games (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Gentoo Games

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2006-10-16 14:48 UTC by Simon Stelling (RETIRED)
Modified:	2006-10-16 15:04 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
suggested patch (exult-1.2-useless-use.patch,783 bytes, patch) 2006-10-16 14:49 UTC, Simon Stelling (RETIRED)	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Simon Stelling (RETIRED) gentoo-dev

2006-10-16 14:48:56 UTC

games-engines/exult-1.2 has two bogus configure switches and therefore USE flags:

configure.ac:
> # Architecture dependent optimisations
> AC_MSG_CHECKING(if we should optimise for MMX)
> AC_ARG_ENABLE(timidity, [  --enable-mmx       Use MMX optimisations [default no]],,enable_mmx=no)
> if test x$enable_mmx = xyes; then
>         AC_MSG_RESULT(yes)
>         CXXFLAGS="$CXXFLAGS -mmmx"
> else
>         AC_MSG_RESULT(no)
> fi

The same goes for 3dnow. Adding -mmmx and -m3dnow is already done through -march , so this is really superfluous. The patch I am about to attach fixes this nonissue. If you don't stop me within a week's time, I'll go and merge it myself.

Comment 1 Simon Stelling (RETIRED) gentoo-dev

2006-10-16 14:49:16 UTC

Created attachment 99832 [details, diff]
suggested patch

Comment 2 Simon Stelling (RETIRED) gentoo-dev

2006-10-16 15:04:35 UTC

<Mr_Bones_> blubb: do it to exult

hush, it's gone