Bug 151397 – x11-libs/libX11-1.0.99.1-r1 with XCB support fails a lock assertion when running vino-2.16.0

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Mike Auty (RETIRED) 2006-10-14 16:25:57 UTC]

Hiya, again, I should be providing a patch but I really haven't the fogiest what's going on in there, so best I can do is report it, sorry...

I have:

x11-libs/libX11-1.0.99.1-r1 with XCB support
x11-libs/libXrandr-1.1.1-r1
x11-libs/libXcomposite-0.3-r1
net-misc/vino-2.16.0

When starting vino-server with:

DISPLAY=":0" /usr/libexec/vino-server --oaf-activate-iid=OAFIID:GNOME_RemoteDesktopServer
and attempting to connect, I get the following:

IOR:0194d4bf2200000049444c3a474e4f4d452f52656d6f74654465736b746f702f5368656c6c3a312e3000fb57030000000054424f540000000101027705000000554e4958000000000a0000006c6f63616c686f73740001052a0000002f746d702f6f726269742d6d696b652f6c696e632d373163342d302d3238623839376637663063653800000000000000caaedfba54000000010102002a0000002f746d702f6f726269742d6d696b652f6c696e632d373163342d302d323862383937663766306365380000001c00000000000000b90868a8ec592828c02b28282828282804000000bd201070010000004800000001006d7002000000050000001c00000000000000b90868a8ec592828c02b28282828282804000000bd20107001000000140000000100000001000105000000000901010000000000
15/10/2006 00:16:27 Autoprobing TCP port 
15/10/2006 00:16:27 Autoprobing selected port 5900
15/10/2006 00:16:27 Advertising security type: 'TLS' (18)
15/10/2006 00:16:27 Advertising authentication type: 'VNC Authentication' (2)
15/10/2006 00:16:27 Advertising security type: 'VNC Authentication' (2)
15/10/2006 00:16:29 Got connection from client 127.0.0.1
15/10/2006 00:16:29   other clients:
vino-server: xcb_xlib.c:50: xcb_xlib_unlock: Assertion `c->xlib.lock' failed.

That last line is obviously the unusual one, the vnc connection then immediately dies.

As ever I'm happy to try out whatever weird and wonderful patches you may want to help get this thing fixed.  If there's any further information I can provide to help, please just ask...  5:)

[Comment 1 Joshua Baergen (RETIRED) 2006-10-15 08:09:16 UTC]

There are still some known issues with XCB and certain X libraries.  You should probably create an upstream bug at https://bugs.freedesktop.org under the 'XCB' product, and make it block https://bugs.freedesktop.org/show_bug.cgi?id=6797.

[Comment 2 Mike Auty (RETIRED) 2006-10-15 09:09:23 UTC]

Filed upstream as https://bugs.freedesktop.org/show_bug.cgi?id=8650, I'll try to keep this bug updated with anything useful posted on the other bug...

[Comment 3 Joshua Baergen (RETIRED) 2006-10-15 11:58:40 UTC]

Thanks :)

[Comment 4 Joshua Baergen (RETIRED) 2006-10-15 20:14:07 UTC]

I just added DisplayUnlock patches for libXfixes and libXi.  See if that fixes your issues.

[Comment 5 Josh Triplett 2006-10-16 03:18:56 UTC]

This assertion does not indicate a bug in XCB or Xlib/XCB; rather, it indicates a locking bug in a caller of Xlib/XCB: a call to UnlockDisplay without the display locked.  In this case, XDamageQueryVersion in libXDamage called UnlockDisplay and SyncHandle without having locked the display.  I've fixed this upstream in libXdamage master, in commit 31829be123a9ce58bf8e0c4718815b7b63d0d512.

[Comment 6 Mike Auty (RETIRED) 2006-10-16 06:23:39 UTC]

Thanks, the libXfixes/libXi fixes seem to have done the trick (and indeed I'm typing this to your through vino...  5:)

Now if I could only figure out why it's not liking my password hash, but that's for another time...  Thanks again for helping fix up such a vague bug report!  5:)

[Comment 7 Joshua Baergen (RETIRED) 2006-10-16 18:48:53 UTC]

This also needs the libXdamage fix...

[Comment 8 Joshua Baergen (RETIRED) 2006-10-16 18:56:25 UTC]

libXdamage patch has been committed.