Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 149590 - net-im/psi-0.10-r1 does not install czech language file (but also the other)
Summary: net-im/psi-0.10-r1 does not install czech language file (but also the other)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal
Assignee: Przemyslaw Maciag (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-30 01:38 UTC by Robert Wolf
Modified: 2006-11-12 15:11 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
psi-0.10-r1.ebuild (psi-0.10-r1.ebuild,10.47 KB, text/plain)
2006-09-30 15:04 UTC, Przemyslaw Maciag (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Wolf 2006-09-30 01:38:11 UTC
Hi,

there is a bug in code in ebuild file to add language files to psi installation. This bug is also in psi-0.10.ebuild file, but it is hidden.

The psi-0.10.ebuild uses language files of version 0.9.3 for my lang (czech). In file psi_cs-0.9.3-a.tar.bz2 the language file in in directory langs.

But in file psi_cs-0.10-a.tar.bz2 the language file is in root directory. There is a code in ebuild file:

--------------
cd ${WORKDIR}
if ! [ -d langs ] ; then
    mkdir langs
fi
local i
for i in  `ls -c1 | grep "\.{ts,qm}$"` ; do
    mv $i langs
done
--------------

this code works fine for language archives version 0.9.3, because the language files are already packed in directory langs. But for version 0.10, the languages are packed into root directory. Then the code mv $i langs should be done, but there is a bug in this command

`ls -c1 | grep "\.{ts,qm}$"`

the regular expression is not correct. Either there should be 

`ls -c1 | grep "\.\(ts\|qm\)$"`

or 

`ls -c1 *.{ts,qm}` , but this shows error messages about non-existing *.ts files. Maybe the best solution is to use find command:

find . -maxdepth 1 -type f  \( -name "*.qm" -o -name "*.ts" \)

and maybe change the whole code 

--------
for i in  `ls -c1 | grep "\.{ts,qm}$"` ; do
    mv $i langs
done
--------

to 

find . -maxdepth 1 -type f  \( -name "*.qm" -o -name "*.ts" \) -print0 | xargs -0r mv --target-directory=langs

Can you update the ebuild some way?
Comment 1 Przemyslaw Maciag (RETIRED) gentoo-dev 2006-09-30 13:38:17 UTC
(In reply to comment #0)
> Hi,

Hi!

> Can you update the ebuild some way?
I checked only polish translation... :/ Which is obviously ok, because it's old one...

I will fix it today.

Thx for reporting!

Regards,
Przemek
Comment 2 Przemyslaw Maciag (RETIRED) gentoo-dev 2006-09-30 15:04:07 UTC
Created attachment 98474 [details]
psi-0.10-r1.ebuild

I corrected langpackgs and made new tarballs for problematic ones. You can use ebuild I submitted here (for langpacks nothing else has to be done).

I have to work on 'extras' version for a next day (maybe one or two more...).

Cheers,
Przemek
Comment 3 Przemyslaw Maciag (RETIRED) gentoo-dev 2006-11-12 15:11:12 UTC
Fixed in psi-0.10-r2 (-r1 was droped).

Cheers,
Przemek