Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 149308 - sys-fs/multipath-tools 0.4.7 wrong path in init script
Summary: sys-fs/multipath-tools 0.4.7 wrong path in init script
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: AMD64 Linux
: High normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-27 07:50 UTC by Jiri Tyr
Modified: 2006-11-15 08:45 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jiri Tyr 2006-09-27 07:50:04 UTC
I have installed sys-fs/multipath-tools 0.4.7 and I have found an error in the init.d script. In /etc/init.d/multipathd file is path /usr/sbin/multipathd and it should be /sbin/multipathd. Also, when I try to stop already started multipathd daemon, it do not stop it and I have to kill it manualy.
Comment 1 Jiri Tyr 2006-09-27 23:37:57 UTC
One more thing is not correct. If I add alias into the multipath.conf, it do not create the /dev/mapper/alias_name. I think it is because of the udev configuration.
Comment 2 SpanKY gentoo-dev 2006-09-28 01:54:46 UTC
fixed in 0.4.7-r1, thanks for the report !
Comment 3 Jiri Tyr 2006-09-29 01:33:46 UTC
(In reply to comment #2)
> fixed in 0.4.7-r1, thanks for the report !

It still doesn't create the alias. In "man devmap_name" is mentioned something else then what is in /etc/udev/rules.d/40-multipath.rules:

KERNEL="dm-[0-9]*", PROGRAM="/sbin/devmap_name %M %m", \
NAME="%k", SYMLINK="%c"

It would be nice to have alias instead of the bloody mplath device name.
Comment 4 Jiri Tyr 2006-10-04 02:36:46 UTC
(In reply to comment #3)
> (In reply to comment #2)
> > fixed in 0.4.7-r1, thanks for the report !
> 
> It still doesn't create the alias.

OK, it was my fault. I had badly defined device in multipath.conf.

But it still doesn't stops multipathd if I use the "/etc/init.d/multipathd stop". I solved that if I changed the stop command to this one:
start-stop-daemon --stop --quiet --exec /sbin/multipathd

I have triend to add --retry 5 to KILL the process after 5 secs but it didn't worked for me. Could you change it in the ebuild? Thanks.
Comment 5 SpanKY gentoo-dev 2006-11-09 16:44:50 UTC
works fine for me
Comment 6 Jiri Tyr 2006-11-10 02:36:19 UTC
(In reply to comment #5)
> works fine for me

What works for you? My solition or current solution what is in the ebuild now? What HW do you have?
Comment 7 SpanKY gentoo-dev 2006-11-12 21:10:12 UTC
using start/stop works for me ... i dont actually use device mapper
Comment 8 Jiri Tyr 2006-11-13 00:50:53 UTC
OK, I vote for to replace old stop line in the init.d script with this one:
start-stop-daemon --stop --quiet --exec /sbin/multipathd
Comment 9 SpanKY gentoo-dev 2006-11-13 12:08:17 UTC
no ... it produces a pid file so we're going to use it
Comment 10 Jiri Tyr 2006-11-14 00:45:18 UTC
(In reply to comment #9)
> no ... it produces a pid file so we're going to use it

But if the pid way doesn't work properly, then you sould switch to the exec way. You sould search way how it works for everybody and not only for somebody!
Comment 11 SpanKY gentoo-dev 2006-11-14 16:06:02 UTC
except that it does

you're probably experiencing a bug that we've fixed elsewhere

in the meantime, change --pid to --pidfile in your local copy
Comment 12 Jiri Tyr 2006-11-15 08:45:00 UTC
(In reply to comment #11)
> except that it does
> 
> you're probably experiencing a bug that we've fixed elsewhere
> 
> in the meantime, change --pid to --pidfile in your local copy
> 

Thank you. With "--pidfile" instead of the "--pid" it works very well. Would be possible to change it in a portage?