Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 149226 - sys-cluster/torque-2.1.2-r1 deletes needed dirs on re-emerge
Summary: sys-cluster/torque-2.1.2-r1 deletes needed dirs on re-emerge
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Cluster Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-26 13:42 UTC by Ian Stakenvicius
Modified: 2010-09-10 19:00 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Stakenvicius 2006-09-26 13:42:51 UTC
When re-emerging (upgrading, rebuilding) torque, dirs that do not have any configuraiton files in them are cleaned up when the previously installed version is unmerged.

Some keepdirs should fix this, I think.  Changing the 'install' command to a 'keepdir' command (and making the chroot mandatory) in pbs_createdirs seems to fix it on my system, at any rate.
Comment 1 Jakub Moc (RETIRED) gentoo-dev 2006-09-26 13:48:48 UTC
Don't restrict bugs without any reason. Just leave the checkboxes alone.
Comment 2 Donnie Berkholz (RETIRED) gentoo-dev 2006-09-26 14:05:10 UTC
Good catch. We can't just change it, because the function also gets run in pkg_postinst().
Comment 3 Ian Stakenvicius 2006-09-26 14:09:07 UTC
yeah, plus only certain dirs need it, and it depends on whether we're USEing 'server' or not..  
Comment 4 Donnie Berkholz (RETIRED) gentoo-dev 2006-09-26 14:16:13 UTC
I added a little fix into 2.1.2-r1 -- should hit rsync in an hour or so.
Comment 5 Ian Stakenvicius 2006-09-27 08:47:12 UTC
Almost perfect.  all appropriate dirs are kept, however pbs_server for some reason seems to think that the .keep file in server_priv/queues is a queue file and tries to parse it.  This is actually messing up my real queue on server restart oddly enough :(

I'm working on a patch to make pbs_server ignore dot-files, as it seems super-easy and i can't see this limitation causing any operational issues..  Would this be better than risking server_priv/queue be removed due to no .keep?
Comment 6 Ian Stakenvicius 2006-09-27 09:49:35 UTC
update -- a browse of the source indicates that que_recov reading an empty file should clean itself up properly, so my issue must be elsewhere (possibly the way queues are malloc'd).. 

So if we dont mind the error message on pbs_server start, i guess nothing needs to change.