Bug 149168 – x11-plugins/enigmail-0.94.1 language packs fix

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Fab 2006-09-26 05:12:37 UTC]

Hi,

In bug #144628, Doug Goldstein ask for any idea to fix the LINGUAS issue for enigmail-0.94.1. I think I found a logic.

I'll attach :
 - patch for the ebuild, to have all the language packs from enigmail.mozdev.org 
   (works fine for me with LINGUAS="fr")
 - explanations on how I set the LANGS && SHORTLANGS variables
 - a little script to run tests.


With this patch, output from emerge is :

--------------------------------
# emerge -pv enigmail

These are the packages that would be merged, in order:

Calculating dependencies ... done!
[ebuild   R   ] x11-plugins/enigmail-0.94.1  LINGUAS="fr -ca -cs -de -el -es -es_AR -es_ES -fi -hu -it -ja -ko -nb -nb_NO -nl -pl -pt -pt_BR -pt_PT -ru -sk -sl -sv -sv_SE -zh_CN" 0 kB 
--------------------------------


Thanks.

[Comment 1 Fab 2006-09-26 05:14:22 UTC]

Created attachment 98114 [details, diff]
patch for the ebuild

[Comment 2 Fab 2006-09-26 05:15:10 UTC]

Created attachment 98116 [details]
how I set the variables

[Comment 3 Fab 2006-09-26 05:16:08 UTC]

Created attachment 98117 [details]
little bash script to run tests

[Comment 4 Walter Meinl 2006-09-26 11:02:49 UTC]

(In reply to comment #1)
> Created an attachment (id=98114) [edit]
> patch for the ebuild
> 

good work Fabrice!
Just as a comment (not related to your work but what could be done in addition by the maintainer)
put all the enigmail-language-packs available in distdir on the mirrors, such that we don't have to deal with the original site for download as is done for the language packs from tb and ff. Then we could go back
 for X in ${LANGS} ; do
 	SRC_URI="${SRC_URI}
-linguas_${X/-/_}? ( http://www.mozilla-enigmail.org/downloads/lang/0.9x/${PN}-${X}-0.9x.xpi )"
+linguas_${X/-/_}? ( mirror://gentoo/${PN}-${X}-0.9x.xpi )"
(same change for SHORTLANGS)

secondly, in the new ebuild WANT_AUTOCONF="2.1" is called twice, first time at the top, second time before calling eautoreconf, one time would be sufficient (just a little bit of cosmetics)

[Comment 5 Doug Goldstein (RETIRED) 2006-09-27 08:41:25 UTC]

  IUSE.invalid                   1
   x11-plugins/enigmail/enigmail-0.94.1.ebuild: linguas_pt_PT

Reopen this bug if it's not tweaked by me right.

[Comment 6 Mihai Moldovan 2006-09-27 10:31:44 UTC]

It was everything right. Patched worked fine (I'm using de).

However -- I do not understand, why Enigmail 0.94.1 got removed from portage until yesterday (the newest version is now 0.94.0-r5 AND I have still 0.94.1 installed - - lol) and this bug report wasn't findable anymore by bugs.gentoo.org search, but accessable via the link in my browsers' history.

Please, let the patch flow into the current tree ASAP.

[Comment 7 Mihai Moldovan 2006-09-27 10:38:23 UTC]

(In reply to comment #6) 
> However -- I do not understand, why Enigmail 0.94.1 got removed from portage
> until yesterday (the newest version is now 0.94.0-r5 AND I have still 0.94.1
> installed - - lol) and this bug report wasn't findable anymore by
> bugs.gentoo.org search, but accessable via the link in my browsers' history.

My fault, I should have udpdate eix. :P

> Please, let the patch flow into the current tree ASAP.

Great, thank you! Merged w/ current ebuild, builds fine, greetings. :)

[Comment 8 Fab 2006-09-27 11:42:51 UTC]

(In reply to comment #5)
>   IUSE.invalid                   1
>    x11-plugins/enigmail/enigmail-0.94.1.ebuild: linguas_pt_PT
> 

Just one little question : how did you get this message ?
Thanks.