Bug 149146 – dev-util/cmake - 'FindQt4.cmake' is bugged

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Mate SOOS 2006-09-26 01:27:17 UTC]

Hi!

The file /usr/share/cmake/Modules/FindQt4.cmake has a hug bug that does not let cmake even use the file. At this point in the file:

MACRO(QT4_APPEND_INCLUDES_FLAG FLAG)
  IF(${FLAG})
    SET(QT_INCLUDES ${QT_INCLUDES} "${${FLAG}}")
  ENDIF(${FLAG})
ENDMACRO(APPEND_INCLUDE_FLAG)

As anyone can see, this is bugged. The correct version is of course:

MACRO(QT4_APPEND_INCLUDES_FLAG FLAG)
  IF(${FLAG})
    SET(QT_INCLUDES ${QT_INCLUDES} "${${FLAG}}")
  ENDIF(${FLAG})
ENDMACRO(QT4_APPEND_INCLUDES_FLAG)

(note that both the QT4_ prefix and the S at the end of INCLUDES is missing)

The cmake actually will not compile the CMakeLists.txt file with the line "find_package(Qt4 REQUIRED)" in it until this bug is corrected (i.e. I think even KDE4 will not compile :O )

Please correct! Thx in advance,

Mate SOOS

[Comment 1 Jakub Moc (RETIRED) 2006-09-26 01:34:41 UTC]

Don't restrict bugs without any reason. Just leave the checkboxes alone.

[Comment 2 Caleb Tennis (RETIRED) 2006-09-26 03:28:51 UTC]

Have you contacted the cmake developers about this?  I don't think I'm qualified to make this decision.

[Comment 3 Mate SOOS 2006-09-26 03:47:24 UTC]

The newest cmake version (2.4-patch 2) actually works and of course this bug is corrected there. 

By the way, I just noticed that even with the bug I corrected, the old (i.e. stable) cmake will not 'eat' the FindQt4.cmake, but it will only report 'minor' errors (and no Qt4 application will compile). So, maybe it is not a good idea to correct this bug: just make the 2.4-patch 2 'stabe', because cmake is evolving at a very rapid rate, and this cmake is mostly unusable for what cmake is most used for nowadays: cross-compiling KDE4, and Qt4 applications in general.

Just my 2 cents.

M

[Comment 4 Mate SOOS 2006-09-26 03:47:24 UTC]

The newest cmake version (2.4-patch 2) actually works and of course this bug is corrected there. 

By the way, I just noticed that even with the bug I corrected, the old (i.e. stable) cmake will not 'eat' the FindQt4.cmake, but it will only report 'minor' errors (and no Qt4 application will compile). So, maybe it is not a good idea to correct this bug: just make the 2.4-patch 2 'stabe', because cmake is evolving at a very rapid rate, and this cmake is mostly unusable for what cmake is most used for nowadays: cross-compiling KDE4, and Qt4 applications in general.

Just my 2 cents.

Máté

[Comment 5 Stefan Schweizer (RETIRED) 2006-11-29 10:44:38 UTC]

thanks, will be solved with stabilizing in bug 155307

[Comment 6 Tomáš Chvátal (RETIRED) 2009-08-09 11:39:39 UTC]

bugzie

[Comment 7 Tomáš Chvátal (RETIRED) 2009-08-09 11:39:56 UTC]

This bug is fixed with new version of cmake.