Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 148784 - Add support for VIA padlock in sys-fs/loop-aes
Summary: Add support for VIA padlock in sys-fs/loop-aes
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Stefan Schweizer (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-23 08:17 UTC by Robert Kerr
Modified: 2006-10-04 08:51 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
loop-aes-3.1d.ebuild.diff (loop-aes-3.1d.ebuild.diff,629 bytes, patch)
2006-09-23 13:49 UTC, Alon Bar-Lev (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Kerr 2006-09-23 08:17:05 UTC
Please consider adding support for the VIA padlock hardware AES acceleration in loop-aes. From the loop-aes README:

"If you want enable VIA padlock hardware AES xcrypt instructions, specify
PADLOCK=y on make command line. If enabled, presence of VIA padlock
instructions is detected at run time, but code still works on non-padlock
processors too."

I see two options here, either make PADLOCK=y the default (should still run on other processors) or (probably more preferable) add a padlock USE flag and do something like:

use padlock && BUILD_PARAMS="${BUILD_PARAMS} PADLOCK=y"
Comment 1 Jakub Moc (RETIRED) gentoo-dev 2006-09-23 10:59:09 UTC
*** This bug has been marked as a duplicate of 145537 ***

*** This bug has been marked as a duplicate of 145537 ***
Comment 2 Robert Kerr 2006-09-23 11:41:19 UTC
Bug 145537 does not appear to be related?

Padlock support in loop-aes would neither use nor require support in openssl.

Upstream loop-aes already contains it's own padlock implementation as a compile time option but the ebuild does not enable it. All that's needed is for the ebuild to allow that compile time option to be set?
Comment 3 Stefan Schweizer (RETIRED) gentoo-dev 2006-09-23 13:05:10 UTC
CCing main contributor for this :)

can you please contribute a patch?
Comment 4 Alon Bar-Lev (RETIRED) gentoo-dev 2006-09-23 13:49:52 UTC
Created attachment 97891 [details, diff]
loop-aes-3.1d.ebuild.diff

Sure!
Although I don't have the hardware to test it, it seems to work without the hardware, but I notice a performance impact.

Add new use flag, padlock:
Use VIA padlock instructions, detected at run time, code still works on non-padlock processors too.
Comment 5 Robert Kerr 2006-09-24 03:55:46 UTC
Works great, thanks! Nearly triples the IO speed on a C7.

If you need any testing on this hardware in the future please feel free to CC me.
Comment 6 Stefan Schweizer (RETIRED) gentoo-dev 2006-10-04 08:51:42 UTC
thanks, fixed