Bug 148778 – net-libs/gnutls-1.4.4-r1 depends on sys-devel/gettext in non-nls build

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description tka 2006-09-23 07:10:51 UTC]

Problem:
The gnutls-1.4.4-r1 ebuild unconditionally (r)depends on gettext, even if the nls use flag is not set.

Solution:
The ebuild should check the nls use flag and only add sys-devel/gettext to RDEPEND if the flag is set.

I'll attatch a fixed ebuild.

[Comment 1 tka 2006-09-23 07:13:41 UTC]

Created attachment 97852 [details]
Fixed ebuild

[Comment 2 tka 2006-09-23 07:17:39 UTC]

Created attachment 97854 [details, diff]
Fix as patch

This is a diff between the original and the fixed ebuild file.

[Comment 3 Jakub Moc (RETIRED) 2006-09-23 07:18:57 UTC]

Comment on attachment 97852 [details]
Fixed ebuild

How exactly will this work? You didn't change anything except for adding the use flag. 

You need $(use_enable nls) there (and no, I didn't check if it's even honored by the build system).

[Comment 4 Jakub Moc (RETIRED) 2006-09-23 07:22:58 UTC]

Plus gettext shouldn't be in RDEPEND:

RDEPEND="nls? ( virtual/libintl )
   ...."

DEPEND="${RDEPEND}
   nls? ( sys-devel/gettext )"

[Comment 5 tka 2006-09-23 07:39:27 UTC]

(In reply to comment #3)
> (From update of attachment 97852 [details] [edit])
> How exactly will this work? You didn't change anything except for adding the
> use flag. 

I added a check to RDEPEND, this is how it's done in other ebuilds and with the other use flags in the gnutls ebuild. The important part of the fix is:

-	sys-devel/gettext"
+	nls? ( sys-devel/gettext )"

in RDEPEND=...

So please check it again.

[Comment 6 tka 2006-09-23 07:41:52 UTC]

(In reply to comment #4)
> Plus gettext shouldn't be in RDEPEND:
> 
> RDEPEND="nls? ( virtual/libintl )
>    ...."
> 
> DEPEND="${RDEPEND}
>    nls? ( sys-devel/gettext )"
> 

Well, I just want to get gettext out of my non-nls system.
Someone else put in into RDEPNED in the first place.

[Comment 7 Daniel Black (RETIRED) 2006-09-23 15:16:13 UTC]

by bad. Thanks Timo for bringing it to my attentioned. Problem should be fixed now.