Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 146956 - [Patch] Various KWlanInfo issues
Summary: [Patch] Various KWlanInfo issues
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] KDE (show other bugs)
Hardware: All Linux
: Low minor (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-09 08:27 UTC by Ingo van Lil
Modified: 2007-05-07 16:48 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Proposed patch for all three issues (kwlaninfo-0.9.4-misc.patch,2.00 KB, patch)
2006-09-09 08:28 UTC, Ingo van Lil
Details | Diff
New version of the patch. (kwlaninfo-0.9.4-ipw2200.patch,2.49 KB, patch)
2006-12-04 13:13 UTC, Ingo van Lil
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ingo van Lil 2006-09-09 08:27:33 UTC
I had to correct a couple of issues in KWlanInfo before the values it displayed on my system made any sense:

- The iwreq structure (particularly the iwr.data.length field) isn't properly initialized before invoking the SIOCGIWESSID and SIOCGIWNICKN ioctls to query the ESSID and Nickname.

- The program assumes the SIOCGIWFREQ ioctl to return the current frequency, but some drivers return the channel number instead (though this is deprecated). I have added a trivial workaround for that case. At least the ipw2200 driver used to behave that way before version 1.1.3, other drivers might still do so.

- The displayed channel number might be wrong due to inaccurate rounding.

I've sent my patch to the original author about half a year ago, but unfortunately he's to busy to apply it and release a new version. So, I figured it might still be useful to other Gentoo users.
Comment 1 Ingo van Lil 2006-09-09 08:28:24 UTC
Created attachment 96478 [details, diff]
Proposed patch for all three issues
Comment 2 Charlie Shepherd (RETIRED) gentoo-dev 2006-11-20 14:30:57 UTC
(In reply to comment #0)
> I've sent my patch to the original author about half a year ago, but
> unfortunately he's to busy to apply it and release a new version.

6/8 months ago? Please consider filing a bug upstream (bugs.kde.org) - we are unlikely to support patches refused by upstream. If upstream cba to accept it, it reflects pretty poorly on them.
Comment 3 Ingo van Lil 2006-11-20 15:02:59 UTC
(In reply to comment #2)
> Please consider filing a bug upstream (bugs.kde.org) - we are
> unlikely to support patches refused by upstream.

kwlaninfo is not an official KDE project, is it? I don't think they feel responsible for it. Upstream, in this case, refers to a single coder who hasn't shown any activity for almost two years now.
Anyway, since there doesn't seem to be any equivalent tool around (what with kwirelessmonitor growing more and more unstable and finally being dropped from portage) I thought my patches might actually be useful to others. They certainly are to me.
Comment 4 Ingo van Lil 2006-12-04 13:13:30 UTC
Created attachment 103349 [details, diff]
New version of the patch.

A recent change in the kernel's wireless layer triggered yet another bug in kwlanino, now the applet will display an error message due to a failed ioctl() whenever the mouse hovers above it. New patch attached.
Comment 5 Wulf Krueger (RETIRED) gentoo-dev 2007-04-27 15:11:14 UTC
I've just sent an email to upstream to ask about KWlanInfo's status and this 
patch.
Comment 6 Wulf Krueger (RETIRED) gentoo-dev 2007-04-29 20:46:41 UTC
Peter (upstream) just informed me that he will be using the patch for version 
0.9.5 which he expects to provide in a few days. He's going to notify me when 
it's out.
Comment 7 Wulf Krueger (RETIRED) gentoo-dev 2007-05-07 16:47:39 UTC
This patch was included in version 0.9.5 which I've just committed to CVS.
Comment 8 Wulf Krueger (RETIRED) gentoo-dev 2007-05-07 16:48:11 UTC
This patch was included in version 0.9.5 which I've just committed to CVS.