Bug 146796 – libgphoto2 doesn't work with dbus-0.9x

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Mart Raudsepp 2006-09-07 22:54:12 UTC]

libgphoto2 uses the deprecated (and removed in dbus-0.90) dbus_connection_disconnect in libgphoto2_port/disk/disk.c
This causes gphoto2 to fail when it dlopens this part of libgphoto2, leading to no photo acquiring being possible.

Removing the dbus_connection_disconnect call fixes the issue.
Yes, I know dbus_connection_close is the replacement, but see upstream changes:

http://svn.sourceforge.net/viewvc/gphoto/trunk/libgphoto2/libgphoto2_port/disk/disk.c?r1=8834&r2=9149
changes dbus_connection_disconnect to dbus_connection_close

http://svn.sourceforge.net/viewvc/gphoto/trunk/libgphoto2/libgphoto2_port/disk/disk.c?r1=9149&r2=9150
Removes the dbus_connection_close with the commit message "no close() ... or we close the wrong bus".

The summary of these changes is to remove the dbus_connect_disconnect call, as seen on the reference URL.

I have tested it locally through step-by-step ebuild command, and it works good without dbus_connection_disconnect, to the extent that gphoto2 is able to fetch photos instead of giving a symbol lookup error - I have no idea if the complete removal done by upstream is the correct fix.

[Comment 1 Florian Steinel 2006-09-30 11:54:37 UTC]

Created attachment 98459 [details, diff]
change from dbus_connection_disconnect to dbus_connection_close

[Comment 2 Florian Steinel 2006-09-30 11:56:44 UTC]

Created attachment 98460 [details, diff]
remove dbus_connection_disconnect

[Comment 3 Florian Steinel 2006-09-30 11:58:35 UTC]

Created attachment 98461 [details, diff]
remove dbus_connection_disconnect

[Comment 4 Florian Steinel 2006-09-30 12:10:09 UTC]

Created attachment 98463 [details, diff]
diff libgphoto2-2.2.1-r1.ebuild libgphoto2-2.2.1-r2.ebuild

libgphoto2-2.2.1-r2 = with the dbus patch

[Comment 5 Frank 2006-10-17 13:51:01 UTC]

(In reply to comment #4)
> Created an attachment (id=98463) [edit]
> diff libgphoto2-2.2.1-r1.ebuild libgphoto2-2.2.1-r2.ebuild
> 
> libgphoto2-2.2.1-r2 = with the dbus patch
> 

When is -r2 available in portage ?

The diff refers to another .patch file  /usr/portage/media-libs/libgphoto2/files/libgphoto2-2.1.6-dbus-connection.patch

that's not in portage.

[Comment 6 Hanno Böck 2006-11-03 05:17:09 UTC]

*** Bug 153899 has been marked as a duplicate of this bug. ***

[Comment 7 Hanno Böck 2006-11-03 05:20:42 UTC]

liquidx, gnome-herd: mind if I commit this? Asked upstream, patch should be okay and not break old versions.

[Comment 8 John N. Laliberte (RETIRED) 2006-11-03 06:33:42 UTC]

hanno, go ahead, thanks.

[Comment 9 Doug Goldstein (RETIRED) 2006-11-07 00:06:00 UTC]

Please commit this soon Hanno, D-Bus 0.95 will be unleashed on the ~arch tree soon enough.

[Comment 10 Hanno Böck 2006-11-07 04:02:45 UTC]

fixed