Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 146789 - app-shells/fish-1.21.12.ebuild (Update)
Summary: app-shells/fish-1.21.12.ebuild (Update)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Other
: High enhancement (vote)
Assignee: Donnie Berkholz (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-07 20:48 UTC by Myrddin Emrys
Modified: 2006-09-23 23:18 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
fish-1.21.12.ebuild (fish-1.21.12.ebuild,1.02 KB, text/plain)
2006-09-07 20:50 UTC, Myrddin Emrys
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Myrddin Emrys 2006-09-07 20:48:33 UTC
This is an update to the Friendly Interactive SHell (fish). The current ebuild (version 1.21.8) is somewhat broken because it requires X even if you set -X. 1.21.8 requires Doxygen, which requires X... this requirement was dropped in later versions, allowing fish to be installed without X on the system.

Hence my submission. I only had to modify the ebuild to remove the doxygen requirement... nothing else from the 1.21.8 ebuild was altered. It emerged fine onto my system but this is the first time I've altered an ebuild, so please doublecheck to make sure I did not do something wrong.

I would like to point something out however... the old ebuild, 1.21.8, appears to disable xsel (--without-xsel) whether or not the X flag is set... this is a bug I think, but I don't know how to fix it. This bug is in my ebuild, 1.21.12 as well. If someone could fix that I would be grateful.

Myrddin
Comment 1 Myrddin Emrys 2006-09-07 20:50:33 UTC
Created attachment 96362 [details]
fish-1.21.12.ebuild
Comment 2 Frederik 'Freso' S. Olesen 2006-09-17 03:13:42 UTC
Simply using "$(use_with X xsel)" instead of "--without-xsel" should do the trick. I haven't tried though.

But, wait, I believe that the "--without-xsel" actually tells fish not to compile the xsel included in its source, so it *should* actually _always_ be passed to the compiler, to avoid having two xsel's installed (x11-misc/xsel + app-shells/fish) or having an xsel which doesn't function (due to no installed X).
fish itself will find out whether there's an xsel installed, whether or not it's the one that came from fish's source or from its own source.
Comment 3 Frederik 'Freso' S. Olesen 2006-09-17 03:16:28 UTC
Oh, and I'd say to keep the ewarn until fish-1.22.
Comment 4 Donnie Berkholz (RETIRED) gentoo-dev 2006-09-23 23:18:42 UTC
Bumped in the tree, thanks!