Hello, We had this discussion at bug#139215. The admin is optional in official tomcat distribution... So you should add admin use flag. Struts is not part of the zip file. But even if you think you should build admin by default. You cannot: cd server/webapps/admin/WEB-INF/lib rm -f struts.jar java-pkg_jar-from struts-1.2 struts.jar cd ${base} Without having struts dependency...
*** This bug has been marked as a duplicate of 120752 ***
Not duplicate of bug#120752. You should add struts to RDEPEND and/or DEPEND. But better add the admin use flag...
The admin use flag is under condsideration but there is no guarantees it will be added. Nor the struts dep removed. Closing this bug once again. Please do not re-open unless you provide a patch. There are more important things on the feature enchancement list. An admin use flag is at the very bottom if it will ever be implemented. Since upstream does not separate the build process of the admin webapp it will be some time if ever before an admin use flag will be implemented. At this time till upstream changes the build process I have no plans to add a admin use flag.
Dear Mr. William L. Thomson Jr. You are so nice, it is a "pleasure" working with you! Do you, at any stage, read what I wrote?!?!? PEOPLE ARE TRYING TO HELP YOU!!! PEOPLE HAVE NO TIME FOR YOU TO WASTE. You are provider of a service, please remember... And if someone takes the time to comment your work, please, at least, pretend you are nice guy. All the work I've done at bug#139215... And still you give me no credit that, at least, I know what I am talking about. First, > Since upstream does not separate the build process of the admin webapp it will > be some time if ever before an admin use flag will be implemented. At this time > till upstream changes the build process I have no plans to add a admin use > flag. It does compile without struts!!!! Try it your-self... I have no struts on my system and removed the following code: cd server/webapps/admin/WEB-INF/lib rm -f struts.jar java-pkg_jar-from struts-1.2 struts.jar cd ${base} And suprise suprise, it worked! Second, If you so insist to use struts, you *MUST* add dependency to the ebuild. Please refer to attached patch.
Created attachment 96091 [details, diff] tomcat-5.5.17-r2.ebuild.diff
Created attachment 96095 [details, diff] tomcat-5.5.17-r2.ebuild.diff - admin use This is an option to add struts only if admin use. Since it compiles fine without struts... The addition of struts may be optional.
Comment on attachment 96091 [details, diff] tomcat-5.5.17-r2.ebuild.diff Adds struts dependency
Thank you for your time and contributions on bug #139215. You are welcome for me taking my time to review your proposed patch and to make the changes neccessary to implement it. You thank me, I will happily thank you. We have many users who have contributed efforts to Tomcat on Gentoo. Most all of which I have spent time with on irc and/or mailing list. There has always been mutual appreciation. Struts was a dep, that accidentally was removed when working with your proposed modifications. I will see about adding dep back and other struts stuff that was lost when applying the patch. The code you posted is from src_install of the ebuild. That is called AFTER Tomcat and the admin webapp have been built. Struts is required during compile. I fail to see how the admin webapp could work without struts. The binary download for the admin webapp has struts.jar in it. Along with a struts.xml file . There are references in the admin webapps sources to classes in struts. Tomcat can be compiled without struts. It just won't build the admin webapp. As for the admin app, I can't see code wise how it would work without struts. Your statement of "it worked", is without context. Is that referring to compiling, running, or working admin webapp? I have other things of more concern at this time with regard to the Tomcat ebuild. Any further discussion on the admin web app, dep of struts or etc will be post poned to a later date.
The struts patch was partial, more was removed per the 1.5 patch and needed to be added back. All struts stuff has been addressed and committed to portage. As for the admin use flag. FYI me and another dev spent over an hour looking into Tomcat's sources and etc. I will considering introducing the admin use flag. But it's not something I have time for right now. Nor something I am concerned about supporting at this time. If you really want to help, I would suggest doing it in areas we need help in now. Like building Tomcat's naming-factory-dbcp.jar. Adding webapp support to the ebuild. Or implementing a startup script developed by a Tomcat dev. All of those are more important on my list than a use flag to not install a minor webapp, and drop a single dep. I appreciate your patch to introduce the admin use flag. However it's not complete. There is another reference to the admin webapp in the ebuild it does not address. cp ${S}/container/webapps/admin/admin.xml \ conf/Catalina/localhost Please only submit complete patches, not partial ones.
Struts dep is now optoinal as of Tomcat 5.5.20 based on if admin use flag is used or not.
