Bug 145687 – krd-1.5 - kde desktop manager (new ebuild)

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Michael Gisbers 2006-08-31 02:40:23 UTC]

new ebuild for a, maybe, krdc replacement.

[Comment 1 Michael Gisbers 2006-08-31 03:00:10 UTC]

Created attachment 95542 [details]
krd-1.1.ebuild

krd-1.1.ebuild

[Comment 2 Michael Gisbers 2006-09-04 10:51:35 UTC]

Created attachment 95983 [details]
krd-1.1.ebuild

updated mirror-path

[Comment 3 Michael Gisbers 2006-09-20 14:43:41 UTC]

Created attachment 97577 [details]
krd-1.3.ebuild

version update

[Comment 4 Michael Gisbers 2006-09-20 14:44:11 UTC]

version update

[Comment 5 Alex 2007-03-13 23:18:14 UTC]

Because the fact that it's using the KDE eclass, you don't need to specify src_compile(). It's inherited. Anyways, simply removing src_compile and bumping to krd-1.4.ebuild works fine.

Also, net-misc/rdesktop should be added for rdesktop support. And so should net-misc/tightvnc for vnc support.

[Comment 6 Michael Gisbers 2007-03-14 19:34:51 UTC]

Created attachment 113297 [details]
krd-1.4.ebuild

Version bump and ebuild - fixes, please check.

[Comment 7 Alex 2007-03-14 20:29:38 UTC]

Looks good, but since you did it with USE flags, do a pkg_setup() with an if conditional to check if rdesktop or vnc is set. If neither are, die with ewarn or eerror. Since otherwise it has no functionality.

[Comment 8 Michael Gisbers 2007-03-27 11:03:07 UTC]

Created attachment 114596 [details]
krd-1.4.ebuild

Thanks for advice. Please check again.

[Comment 9 Alex 2007-03-27 12:36:18 UTC]

Almost there. Switch ~amd64 with ~x86 (order). And change 

pkg_setup() {
	if ! use rdesktop && ! use vnc ; then
		eerror
		eerror "${PN} requires rdesktop or vnc USE - flag to work."
		die "${PN} requires rdesktop or vnc USE - flag to work."
	fi
}

to

pkg_setup() {
	if ! use rdesktop && ! use vnc ; then
		echo
                eerror "${PN} has no use without rdesktop or vnc support."
                eerror "To have rdesktop or vnc support, please emerge with"
                eerror "USE=\"rdesktop\", USE="\vnc\" or USE=\"rdesktop vnc\"
		die "${PN} requires rdesktop or vnc USE flag(s)"
	fi
}

Just makes the error make a bit more sense, and well, you should always demonstrate the USE examples.

[Comment 10 Alex 2007-03-27 12:43:54 UTC]

Was also just noticing, what's the reason for inheriting eutils? It's not used in the ebuild from what I saw.

[Comment 11 Michael Gisbers 2007-03-27 15:18:58 UTC]

Created attachment 114624 [details]
krd-1.4.ebuild

Thanks for advice. So this one may be the final one.

[Comment 12 Alex 2007-03-27 16:48:07 UTC]

Looks good to me. Good job.

[Comment 13 Michael Gisbers 2007-06-18 18:52:42 UTC]

Created attachment 122433 [details]
krd-1.5.ebuild version bump

[Comment 14 Michael Gisbers 2007-06-19 08:42:23 UTC]

Ebuild is now in the gentoo-sunrise overlay, available here:
http://gentoo-sunrise.org/svn/sunrise/kde-misc/krd

[Comment 15 Wulf Krueger (RETIRED) 2007-10-26 20:47:13 UTC]

(In reply to comment #14)
> Ebuild is now in the 

... tree. Bumped to 1.6. Thanks to all who worked on this!