Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 14542 - Modified cracklib Makefile to replace cc with $(CC)
Summary: Modified cracklib Makefile to replace cc with $(CC)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: J Robert Ray
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-01-25 13:32 UTC by Dana A. Oredson
Modified: 2003-05-22 23:33 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild to change cc to $(CC) in the gentoo-new.patch (cracklib-cc.ebuild,1.05 KB, patch)
2003-01-25 14:41 UTC, Dana A. Oredson
Details | Diff
replacement patch for cracklib-2.7-gentoo-new.diff - tested (cracklib-2.7-gentoo-new.diff,4.14 KB, patch)
2003-01-25 15:53 UTC, Dana A. Oredson
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dana A. Oredson 2003-01-25 13:32:00 UTC
cracklib would not build for me (couldn't find cc).

To fix, I changed all references in the cracklib-2.7-gentoo-new.patch from cc to
$(CC), so it will compile with whatever CC is set to (gcc).
Comment 1 Dana A. Oredson 2003-01-25 14:41:51 UTC
Created attachment 7622 [details, diff]
ebuild to change cc to $(CC) in the gentoo-new.patch
Comment 2 Dana A. Oredson 2003-01-25 14:53:28 UTC
ok, whatever.

Wouldn't build for me as was this morning.
Comment 3 Martin Holzer (RETIRED) gentoo-dev 2003-01-25 14:54:51 UTC
could you paste the error msg ?

your patch doesn't work
Comment 4 Martin Holzer (RETIRED) gentoo-dev 2003-01-25 14:55:18 UTC
also paste
#emerge info
Comment 5 Dana A. Oredson 2003-01-25 15:53:00 UTC
Created attachment 7626 [details, diff]
replacement patch  for cracklib-2.7-gentoo-new.diff - tested

All I did was change references to cc to $(CC) in the
cracklib-2.7-gentoo-new.diff patch.  This one is tested.
Comment 6 Martin Holzer (RETIRED) gentoo-dev 2003-01-25 16:07:33 UTC
there's only one more problem
$(CC) is only set when gcc-config is emerged

i don't want to add gcc-config to DEPEND
Comment 7 Dana A. Oredson 2003-01-25 17:09:56 UTC
Hmm.  The gnu Make documentation says that make defaults $(CC) to gcc.
And cc isn't set on my default gentoo install.  It seems something has to give.

I just unmerge gcc-config, logged out and in again...should $CC not be set,
then?  cuz it is set to gcc right now.
Comment 8 J Robert Ray 2003-01-27 01:58:19 UTC
Have you considered simply changing cc to gcc?
Comment 9 Dana A. Oredson 2003-01-27 09:53:56 UTC
Yes, but that would hard-code out anybody using icc for instance.
Comment 10 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2003-05-12 14:16:51 UTC
Was any resolution made on this ?
Martin: why didn't you want to DEPEND on gcc-config?
Comment 11 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2003-05-22 23:33:25 UTC
I've done all of this now.

gcc-config has been added to DEPEND, as it is in the {R,P,}DEPEND for gcc, so the system WILL have it anyway.

The cc to $(CC) change has been made as the fix to bug #20985 as it was causing problems for a user.

-r7 released as stable now with a fix for PHP after a week in unstable and no problems.