Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 145249 - media-tv/nuppelvideo fails to compile due to -DMMX
Summary: media-tv/nuppelvideo fails to compile due to -DMMX
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High major (vote)
Assignee: Patrick Kursawe (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-08-27 04:40 UTC by Markus Lohse
Modified: 2006-08-28 03:41 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
files/Makefile.patch (Makefile.patch,2.74 KB, patch)
2006-08-27 08:16 UTC, Jakub Moc (RETIRED)
Details | Diff
nuppelvideo-0.52a.ebuild (nuppelvideo-0.52a.ebuild,875 bytes, text/plain)
2006-08-27 08:17 UTC, Jakub Moc (RETIRED)
Details
nuppelvideo-0.52a.ebuild (nuppelvideo-0.52a.ebuild,953 bytes, text/plain)
2006-08-27 08:33 UTC, Jakub Moc (RETIRED)
Details
Ebuild after repackaging (nuppelvideo-0.53a.ebuild,682 bytes, text/plain)
2006-08-28 02:01 UTC, Patrick Kursawe (RETIRED)
Details
Second try (nuppelvideo-0.53a.ebuild,731 bytes, text/plain)
2006-08-28 02:12 UTC, Patrick Kursawe (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Lohse 2006-08-27 04:40:05 UTC
Some wit has messed up nuppelvideo-0.52a by adding crap to the Makefile:

V4LDIR=/usr/src/linux/drivers/char/
COPTS=$(CFLAGS) -I$(V4LDIR)
COPTSRT= -O3 -Wall -DMMX -mcpu=pentium -funroll-loops -fexpensive-optimizations -finline-functions

-- snap - there is a lot more... --

I'm not quite sure which of those "very important optimizations" kept my gcc from compiling this (for an AthlonXP cpu btw.) so I just removed them all except for "-finline-functions" - works.
I assume that everyone has heard about funroll-loops, however for those who have not: http://funroll-loops.org/

I wonder how this could get into portage. No digest verification errors or whatever. And to make things even worse: The author's website appears to be down, so I couldn't contact him.
Comment 1 Jakub Moc (RETIRED) gentoo-dev 2006-08-27 04:48:56 UTC
Well, the sed in ebuild has not much effect, the rice is scattered all over the makefile. Also, X11R6 should go away from -L. 
Comment 2 Jakub Moc (RETIRED) gentoo-dev 2006-08-27 05:38:47 UTC
This junk doesn't compile w/ >=gcc-4 at all.

<snip>
/var/tmp/portage/nuppelvideo-0.52a/temp/cclw1raH.s:3363: Error: suffix or operands invalid for `movq'
/var/tmp/portage/nuppelvideo-0.52a/temp/cclw1raH.s:4943: Error: suffix or operands invalid for `movq'
</snip>

Upstream dead, doesn't compile, makefile all screwed - please, remove this from portage.
Comment 3 Markus Lohse 2006-08-27 07:12:10 UTC
No wait, don't remove it. It compiled sucessfully with gcc 4.1.1 (after fixing the Makefile). Besides it's a nice program.
Comment 4 Jakub Moc (RETIRED) gentoo-dev 2006-08-27 07:55:27 UTC
Well, it's none of the ricer flags, it's stupid -DMMX that makes it bomb out.
Comment 5 Jakub Moc (RETIRED) gentoo-dev 2006-08-27 08:16:08 UTC
Created attachment 95205 [details, diff]
files/Makefile.patch

- nuke -DMMX
- nuke hardcoded CC
- fix make install
Comment 6 Jakub Moc (RETIRED) gentoo-dev 2006-08-27 08:17:59 UTC
Created attachment 95206 [details]
nuppelvideo-0.52a.ebuild

- make the thing respect CFLAGS and CC
- quoting
- nuke useless pkg_postinst(), the homepage is dead
- use emake install
Comment 7 Jakub Moc (RETIRED) gentoo-dev 2006-08-27 08:33:18 UTC
Created attachment 95208 [details]
nuppelvideo-0.52a.ebuild

- also add missing dependencies
Comment 8 Patrick Kursawe (RETIRED) gentoo-dev 2006-08-28 02:01:22 UTC
Created attachment 95259 [details]
Ebuild after repackaging

I applied the patches, got the files mentioned in the old postinstall function from the wayback machine and re-packaged it. Please check if I got it right.
Comment 9 Patrick Kursawe (RETIRED) gentoo-dev 2006-08-28 02:05:43 UTC
Sorry, please wait - just noticed a problem.
Comment 10 Patrick Kursawe (RETIRED) gentoo-dev 2006-08-28 02:12:37 UTC
Created attachment 95260 [details]
Second try

Sorry, this one seems to work for me.
Comment 11 Jakub Moc (RETIRED) gentoo-dev 2006-08-28 02:40:07 UTC
Heh, yeah repackaging the thing seems like saner solution. 

Looks good, just needs to set RDEPED="${DEPEND}" explicitely, otherwise it will get RDEPEND wrong due to inherited eclasses. Thanks.

Comment 12 Patrick Kursawe (RETIRED) gentoo-dev 2006-08-28 03:28:31 UTC
(In reply to comment #11)
> Heh, yeah repackaging the thing seems like saner solution. 
> 
> Looks good, just needs to set RDEPED="${DEPEND}" explicitely, otherwise it will
> get RDEPEND wrong due to inherited eclasses. Thanks.

You mean like in
http://www.gentoo.org/proj/en/devrel/handbook/handbook.xml?part=2&chap=1#doc_chap5
"Never set RDEPEND to DEPEND yourself in an ebuild."?

Ok :-)

In CVS. I hope I remember getting the new version stable in a few weeks...
Comment 13 Jakub Moc (RETIRED) gentoo-dev 2006-08-28 03:41:37 UTC
(In reply to comment #12)
> You mean like in
>http://www.gentoo.org/proj/en/devrel/handbook/handbook.xml?part=2&chap=1#doc_chap5
> "Never set RDEPEND to DEPEND yourself in an ebuild."?

Yeah, a couple of people have been poking kloeri for a few weeks to get it fixed... No luck yet. :)