Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 144845 - sys-apps/acl-2.2.39 - NFS4 ACL support
Summary: sys-apps/acl-2.2.39 - NFS4 ACL support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-08-23 04:35 UTC by Christophe Saout
Modified: 2006-09-23 08:41 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
The CITI acl-2.2.29-CITI_NFS4_ALL-3.dif minus the debian/changelog reject (acl-2.2.29-CITI_NFS4_ALL-3.diff,168.53 KB, patch)
2006-08-23 04:37 UTC, Christophe Saout
Details | Diff
Let "ls -l" indicate additonal ACLs for NFSv4 too. (acl-2.2.39-acl_extended_file-nfs4.diff,1.30 KB, patch)
2006-08-23 04:38 UTC, Christophe Saout
Details | Diff
acl-2.2.39.ebuild patch adding nfsv4 USE flag (acl-2.2.39.ebuild.diff,823 bytes, patch)
2006-08-23 04:39 UTC, Christophe Saout
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christophe Saout 2006-08-23 04:35:18 UTC
NFSv4 uses its own ACL scheme which differs from the POSIX ACL scheme used by other Linux filesystems.

While the NFSv4 kernel server maps the POSIX acls of the underlying filesystem to NFSv4 ACLs over the wire, the client exports the whole NFSv4 ACLs to userspace via its own "system.nfs4_acl" xattr, not via the POSIX xattr.

Therefore the raw libacl doesn' understand these ACLs.

The NFSv4 developers at University of Michigan http://www.citi.umich.edu/projects/nfsv4/ provide a patch for libacl at
http://www.citi.umich.edu/projects/nfsv4/linux/acl-patches/2.2.29-3/acl-2.2.29-CITI_NFS4_ALL-3.dif

When ignoring the reject for debian/changelog this patch applies cleanly to the current acl-2.2.39.

This patch is relatively pain-free. It tries to look up NFSv4 ACLs first (and if it findes them, maps them back to POSIX acls) and falls back to trying POSIX ACLs if the filesystem is not NFSv4.

I've written a small additional patch since the patch missed to extend the acl_extended_file function (which is neat, because e.g. "ls -l" uses to detect whether additional ACLs are set on a directory entry and displays the very useful "+" sign after the default Unix permissions).

As you know, the developers are working in intergrating NFSv4 stuff into the core utilities. Unfortunately this is proceeding very slowly and Gentoo has been patching NFSv4 stuff around here and there. So it would be nice to see NFSv4 ACL  support included.

I've attached a minimal proposal for the acl-2.2.39.ebuild which adds a nfsv4 USE flag. It adds a libnfsidmap dependency (I'm not sure whether to use nfsv4 or nonfsv4 like nfs-utils does).
Comment 1 Christophe Saout 2006-08-23 04:37:24 UTC
Created attachment 94923 [details, diff]
The CITI acl-2.2.29-CITI_NFS4_ALL-3.dif minus the debian/changelog reject
Comment 2 Christophe Saout 2006-08-23 04:38:16 UTC
Created attachment 94924 [details, diff]
Let "ls -l" indicate additonal ACLs for NFSv4 too.
Comment 3 Christophe Saout 2006-08-23 04:39:07 UTC
Created attachment 94925 [details, diff]
acl-2.2.39.ebuild patch adding nfsv4 USE flag
Comment 4 SpanKY gentoo-dev 2006-08-23 17:57:42 UTC
your custom patch should be e-mailed to the nfs list:
nfs@lists.sourceforge.net
Comment 5 Christophe Saout 2006-08-24 04:07:26 UTC
Yes, I've contacted nfsv4@linux-nfs.org though which seems more appropriate for this type of stuff, the other mailing list is more about the kernel anf nfs-utils.
Comment 6 Christophe Saout 2006-09-01 13:39:31 UTC
Note that I sent the patch upstream and got a "thanks". He told me they were planning better ACL support in general but it would be a good think to keep the old way (the patches they currently provide). I haven't seen them release a new official ACL patch though.

http://linux-nfs.org/pipermail/nfsv4/2006-August/004870.html
Comment 7 Christophe Saout 2006-09-02 03:42:20 UTC
Update:

The patch has been included in their GIT repository, which also seems to be more up-to-date than the patches on the CITI homepage:

http://linux-nfs.org/cgi-bin/gitweb.cgi?p=bfields-acl.git;a=summary
Comment 8 SpanKY gentoo-dev 2006-09-23 08:41:48 UTC
in portage then