Bug 144129 – net-wireless/rt2x00-2.0.0_beta3 fails

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Marijn Schouten (RETIRED) 2006-08-16 09:17:29 UTC]

net-wireless/rt2x00-2.0.0_beta3 fails because of errors in rt2500usb.c.

Also it is impossible to only compile for example rt2500pci. This is possible for the 9999 cvs ebuild.

[Comment 1 Jakub Moc (RETIRED) 2006-08-16 09:25:36 UTC]

Reopen with some errors and emerge --info; paranormal abilities missing.

[Comment 2 Marijn Schouten (RETIRED) 2006-08-16 12:57:37 UTC]

lol, sorry :)

The problem is that the module format seems to be dependend upon the kernel version. rt2500pci handles this correctly, but rt2500usb fails to do this. The following patch solves this problem. 

--- rt2500usb.c.orig    2006-08-16 19:19:21.000000000 +0200
+++ rt2500usb.c 2006-08-16 19:19:48.000000000 +0200
@@ -1282,7 +1282,9 @@
 #endif /* CONFIG_RT2X00_DEBUG */

 static struct usb_driver rt2x00_usb_driver = {
+#if LINUX_VERSION_CODE < KERNEL_VERSION(2, 6, 15)
        .owner          = THIS_MODULE,
+#endif /* LINUX_VERSION_CODE < KERNEL_VERSION(2, 6, 15) */
        .name           = DRV_NAME,
        .id_table       = rt2x00_device_usb_tbl,
        .probe          = rt2x00_usb_probe,


Unfortunately while this is the same version that worked for me on the gnewsense (free ubuntu clone) livecd. I get a kernel oops with gentoo kernel 2.6.15-r1 :( just FYI.

[Comment 3 Marijn Schouten (RETIRED) 2006-08-16 12:58:52 UTC]

*** Bug 144147 has been marked as a duplicate of this bug. ***

[Comment 4 Roy Marples (RETIRED) 2006-08-16 13:13:22 UTC]

beta3 requires additional work for 2.6.18-rc kernels too afaik and I see no reason to maintain patches for something that has changed radically in CVS.

Use the cvs ebuild for the time being.

[Comment 5 Marijn Schouten (RETIRED) 2006-08-17 01:07:25 UTC]

It's a tiny patch. I don't see why it shouldn't be fixed. I know this beta3 release is very old, but then again it is the only release. Also if the cvs version worked I wouldn't be here. The fact is that I have seen problemfree operation of the beta3 version under Ubuntu and I want that under Gentoo too. It may not work under newer kernels, but at least I can try. Discussing this costs more time than fixing it.

[Comment 6 Roy Marples (RETIRED) 2006-08-17 04:56:17 UTC]

Boom - it's done. BTW, it oopsies on all kernels I've got, but it compiles which makes you happy.

[Comment 7 Marijn Schouten (RETIRED) 2006-08-17 05:35:24 UTC]

Thanks :) I'm getting the oopses. Still it works in Ubuntu dapper, so I hope to figure out the magic combo. 

[Comment 8 Marijn Schouten (RETIRED) 2006-08-17 07:04:08 UTC]

It seems the patch you included is very wrong. Two ifdef's instead of an if and an endif :(

--- rt2500usb.c.orig    2006-08-17 12:47:35.000000000 +0100
+++ rt2500usb.c 2006-08-17 12:48:21.000000000 +0100
@@ -1282,7 +1282,9 @@
 #endif /* CONFIG_RT2X00_DEBUG */

 static struct usb_driver rt2x00_usb_driver = {
+#ifdef LINUX_VERSION_CODE < KERNEL_VERSION(2, 6, 15)
        .owner          = THIS_MODULE,
+#ifdef /* LINUX_VERSION_CODE < KERNEL_VERSION(2, 6, 15) */
        .name           = DRV_NAME,
        .id_table       = rt2x00_device_usb_tbl,
        .probe          = rt2x00_usb_probe,

[Comment 9 Roy Marples (RETIRED) 2006-08-17 07:07:02 UTC]

Hmmm, how did that happen? Anyway, fixed.