14396 – ebuild.sh: keepdir() should check if .keep already exists

Bug 14396 - ebuild.sh: keepdir() should check if .keep already exists

Summary: ebuild.sh: keepdir() should check if .keep already exists

Status:	RESOLVED FIXED

Alias:	None

Product:	Portage Development
Classification:	Unclassified
Component:	Unclassified (show other bugs)
Hardware:	All All

Importance:	High normal
Assignee:	Nicholas Jones (RETIRED)

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2003-01-22 17:35 UTC by Jukka Salmi
Modified:	2011-10-30 22:19 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
ebuild.sh patch (keepdir.patch,249 bytes, patch) 2003-01-22 17:40 UTC, Jukka Salmi	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jukka Salmi 2003-01-22 17:35:30 UTC

a keepdir() which creates .keep files only if those file don't exist would solve
problems for people who have a read-only /usr/portage, e.g. mounted ro via nfs.

example: all sys-apps/baselayout ebuilds do a 'keepdir /usr/portage'; this makes
the emerge fail if /usr/portage is is read-only. if /usr/portage/.keep exists,
the call to touch(1) in keepdir() is needless.

a patch for /usr/lib/portage/ebuild.sh follows.

Comment 1 Jukka Salmi 2003-01-22 17:40:08 UTC

Created attachment 7541 [details, diff]
ebuild.sh patch

makes ebuild.sh to create .keep files only they don't exist

Comment 2 Jukka Salmi 2003-01-23 11:02:42 UTC

typo in patch comment: s/only they/only if they/

Comment 3 Nicholas Jones (RETIRED) gentoo-dev

2003-01-23 14:08:48 UTC

modified and integrated for next release

Comment 4 Nicholas Jones (RETIRED) gentoo-dev

2003-02-17 06:05:02 UTC

in testing.