Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 143857 - net-analyzer/nload-0.6.0 installs a pre-stripped binary
Summary: net-analyzer/nload-0.6.0 installs a pre-stripped binary
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Netmon project
URL: http://overlays.gentoo.org/dev/phreak...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-08-14 01:45 UTC by Christian Heim (RETIRED)
Modified: 2006-09-16 06:40 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
nload-0.6.0-prevent-stripping.patch (nload-0.6.0-prevent-stripping.patch,2.26 KB, text/plain)
2006-08-14 01:55 UTC, Christian Heim (RETIRED)
Details
nload-0.6.0-prevent-stripping.patch (nload-0.6.0-prevent-stripping.patch,592 bytes, text/plain)
2006-08-14 02:35 UTC, Christian Heim (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Heim (RETIRED) gentoo-dev 2006-08-14 01:45:01 UTC
portage complains about the binary being prestripped.

QA Notice: pre-stripped files found:
/tmp/portage/nload-0.6.0/image/usr/bin/nload

The configure.in is adding -s to LDFLAGS which in fact strips the binary. I've no idea if the Makefile.in patches are really necessary, but I think so.

See above URL (or the attached patch) to fix this issue.
Comment 1 Christian Heim (RETIRED) gentoo-dev 2006-08-14 01:55:27 UTC
Created attachment 94210 [details]
nload-0.6.0-prevent-stripping.patch

This patch removes the LDFLAGS="$LDFLAGS -s" adding from the configure.in and rewrites the install-strip within the Makefile to just read $(MAKE) install
Comment 2 Christian Heim (RETIRED) gentoo-dev 2006-08-14 02:35:22 UTC
Created attachment 94214 [details]
nload-0.6.0-prevent-stripping.patch

Ok, thanks to strerror for the hint, that Makefile.in is recreated from Makefile.am after running eautoreconf. So its enough to just remove the LDFLAGS="$LDFLAGS -s" statement from the configure.in and run eautoreconfig.
Comment 3 Christian Heim (RETIRED) gentoo-dev 2006-09-16 06:40:11 UTC
Just commited the fix. Thanks to dragonheart for letting me fix it.