Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 143433 - dev-java/commons-fileupload-1.1.1 version bump
Summary: dev-java/commons-fileupload-1.1.1 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Java team
URL:
Whiteboard:
Keywords: InOverlay
Depends on: 148210
Blocks:
  Show dependency tree
 
Reported: 2006-08-10 02:13 UTC by Marcus Klein
Modified: 2006-10-10 13:45 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
commons-fileupload-1.1.1.ebuild (commons-fileupload-1.1.1.ebuild,1.59 KB, text/plain)
2006-09-19 09:58 UTC, Miroslav Šulc
Details
commons-fileupload-1.1.1-gentoo.patch (commons-fileupload-1.1.1-gentoo.patch,5.17 KB, patch)
2006-09-19 09:58 UTC, Miroslav Šulc
Details | Diff
patch for commons-fileupload-1.1.1 (in tree) (patch,422 bytes, patch)
2006-10-10 12:06 UTC, Miroslav Šulc
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marcus Klein 2006-08-10 02:13:10 UTC
On http://jakarta.apache.org/commons/fileupload/ version 1.1.1 of commons-fileupload is available. An ebuild is currently only available for version 1.0. Version 1.1 is available for half a year but no ebuild has been made for it.
Comment 1 Petteri Räty (RETIRED) gentoo-dev 2006-08-12 06:03:39 UTC
Initial ebuild here:
https://overlays.gentoo.org/svn/proj/java/migrated-java-experimental-overlay/dev-java/commons-fileupload

This does not work yet because we don't have portlet-api packaged. 
Comment 2 Miroslav Šulc gentoo-dev 2006-09-19 09:58:14 UTC
Created attachment 97433 [details]
commons-fileupload-1.1.1.ebuild

Has dependency to dev-java/portletapi-1.0 which is not in portage and might even change name or version in future.
Comment 3 Miroslav Šulc gentoo-dev 2006-09-19 09:58:44 UTC
Created attachment 97434 [details, diff]
commons-fileupload-1.1.1-gentoo.patch
Comment 4 Miroslav Šulc gentoo-dev 2006-09-22 15:57:38 UTC
The most up-to-date ebuild can be found here: http://overlays.gentoo.org/svn/proj/java/migrated-java-experimental-overlay/dev-java/commons-fileupload/
Comment 5 Josh Nichols (RETIRED) gentoo-dev 2006-10-08 19:29:45 UTC
Added to portage. Thanks for contributing!

One thing to watch out for: make sure you run 'repoman full' in the directory of the ebuild. This does some things like checking the sanity in the depends. In particular, your ebuild for portletapi didn't have keywords for ppc and ppc64, but this ebuild did, and commons-io was missing ppc64 keywords.
Comment 6 Marcus Klein 2006-10-10 02:55:23 UTC
Please don't blame me because I'm reopening this bug. But I don't want to open an new bug for the following issue:

commons-fileupload-1.1.1 depends on commons-io-1.1 but you added the dependency

=dev-java/commons-io-1*

If you download the source tar.gz from commons-fileupload you can see this dependency in the project.xml file for Maven line 165. So I think the dependency should be something like:

>=dev-java/commons-io-1.1
Comment 7 Miroslav Šulc gentoo-dev 2006-10-10 11:45:23 UTC
Unfortunately portage doesn't support depending on a specific SLOT (used for compatible versions of the package) so here I used the dependancy =dev-java/commons-io-1* to make the package depend on version 1.x which is in SLOT="1". This is safer than depending on >=dev-java/commons-io-1.1 which could cause problems when commons-io-2.0 arises which may (or may not) have incompatible API.

So, you are correct, but because portage doesn't support depending on a specific SLOT, I used that dependancy.
Comment 8 Miroslav Šulc gentoo-dev 2006-10-10 12:06:30 UTC
Created attachment 99316 [details, diff]
patch for commons-fileupload-1.1.1 (in tree)

So you were right with the dependency and my solution doesn't work. commons-fileupload-1.1.1 doesn't compile with commons-io-1.0. Here is a patch that solves it. Thanks.
Comment 9 Vlastimil Babka (Caster) (RETIRED) gentoo-dev 2006-10-10 13:45:22 UTC
Fixed, thanks. Hopefully we will have bug 150368 solved before some new slot of commons-io hits the tree :) Thanks for giving me an example for that bug.