Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 143201 - iSight patch should not be applied by default in linux-uvc
Summary: iSight patch should not be applied by default in linux-uvc
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: x86 Linux
: High major (vote)
Assignee: Stefan Schweizer (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-08-08 05:15 UTC by kilian
Modified: 2006-09-01 02:35 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to linux-uvc ebuild adding an isight USE flag (linux-uvc.ebuild.patch,2.18 KB, patch)
2006-08-08 07:18 UTC, kilian
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description kilian 2006-08-08 05:15:16 UTC
As mentioned in last comments of bug #127086, and according to https://lists.berlios.de/pipermail/linux-uvc-devel/2006-July/000663.html, the linux-uvc iSight patch should not be applied by default, as it breaks the driver for other webcams (especially Logitech Quickcam Pro). That patch must only be applied if an appropriate USE flag is selected.
Comment 1 Stefan Schweizer (RETIRED) gentoo-dev 2006-08-08 05:31:42 UTC
I am wondering - can the patch maybe be changed to allow useage of all supported webcam models? Some if; else; calls should be enough. Not a lot of work to do ..

I do not like to add another use flag - and I cannot maintain the other driver as I do not own the hardware. So for now I will leave it as-is - maybe you have a better patch or a better suggestion not including an use flag?
Comment 2 kilian 2006-08-08 07:18:05 UTC
> also adding an useflag would break current isight users - not an easy thing > to solve :(

I can't really understand why the USE-flag solution seems to worry you. USE flags are designed for this precise purpose: allowing to choose at compilation time what features will be included or not. Here, it's only a matter of adding a isight flag, which, if enabled, applies the iSight patch, making Mac users happy, and if not, avoid to apply it, making Logitech & co users happy too.
Current iSight users will just have to be sure the have enabled the isight USE flag before (re)emerging linux-uvc.

Please see the proposed patch.
Comment 3 kilian 2006-08-08 07:18:38 UTC
Created attachment 93752 [details, diff]
patch to linux-uvc ebuild adding an isight USE flag
Comment 4 Henk Spaaij 2006-08-22 15:53:52 UTC
Vote +1 for the use flag.
I've got a Logitech QuickCam Orbit MP which doesn't work with this ebuild because of this patch.
Just wasted a day figuring out what was going on, then found this bug report (that'll teach me to check here first).

Anyway, please resolve this soon. 
Comment 5 Stefan Schweizer (RETIRED) gentoo-dev 2006-09-01 02:35:44 UTC
ok, you have persuaded me, I have commited it together with a new version - i hope I do not get problems with all the current users that I broke ;)

Thanks for filing this bug anyway