Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 142884 - mplayer-1.0_pre8-r1.ebuild: unicode & iconv have no standalone-effect
Summary: mplayer-1.0_pre8-r1.ebuild: unicode & iconv have no standalone-effect
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High trivial (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
: 142885 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-08-05 07:45 UTC by Mark Wehner
Modified: 2007-03-22 07:21 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Wehner 2006-08-05 07:45:41 UTC
When setting USE="unicode" && !USE="iconv" or vice versa, there is no effect on the configure options. Not setting both flags results in broken code on unicode systems (at least for the playback of asf-files). The ebuild contains:

   if use iconv
    then
        use unicode && myconf="${myconf} --charset=UTF-8"
    else
        myconf="${myconf} --charset=noconv"
   fi

In my opinion, it should print at least a warning like:
   
   if use iconv && use unicode
    then 
        myconf="${myconf} --charset=UTF-8"
    else
        myconf="${myconf} --charset=noconv" && einfo "Setting unicode or iconv alone has no Effect."
   fi

[P.S. Why was the split of unicode in unicode & iconv even introduced?]
Comment 1 Jakub Moc (RETIRED) gentoo-dev 2006-08-05 07:50:13 UTC
*** Bug 142885 has been marked as a duplicate of this bug. ***
Comment 2 Luca Barbato gentoo-dev 2006-08-05 08:16:09 UTC
iconv should be always on beside on system that don't have glibc

I'll think about it again.
Comment 3 Łukasz Mierzwa 2006-10-24 14:20:28 UTC
(In reply to comment #2)
> iconv should be always on beside on system that don't have glibc
> 
> I'll think about it again.
> 

iconv must be on for >=mplayer-1.0_rc1, if it's disabled mplayer can freeze on some osd fonts.
Comment 4 Vlastimil Babka (Caster) (RETIRED) gentoo-dev 2006-10-26 00:38:24 UTC
There's similar problem with truetype flag (observed on 1.0_rc1). Looks like it doesn't work standalone, you need to enable truetype AND iconv to actually get freetype -> fontconfig -> SSA/ASS support that everyone needs :)

Checking for freetype >= 2.0.9 ... no (iconv support needed)
Checking for fontconfig ... no (freetype support needed)
Checking for SSA/ASS support ... no (FreeType support needed)
Comment 5 Steve Dibb (RETIRED) gentoo-dev 2006-10-26 22:57:20 UTC
(In reply to comment #4)
> There's similar problem with truetype flag (observed on 1.0_rc1). Looks like it
> doesn't work standalone, you need to enable truetype AND iconv to actually get
> freetype -> fontconfig -> SSA/ASS support that everyone needs :)
> 
> Checking for freetype >= 2.0.9 ... no (iconv support needed)
> Checking for fontconfig ... no (freetype support needed)
> Checking for SSA/ASS support ... no (FreeType support needed)
> 

I've added some notes to the rc1 build to point that out.
Comment 6 Steve Dibb (RETIRED) gentoo-dev 2007-03-22 07:21:16 UTC
should be fixed in 1.0_rc2_pre20070321, let me know if otherwise.