Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 142057 - cups ebuild postinst einfo improvements
Summary: cups ebuild postinst einfo improvements
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Printing Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-07-28 22:47 UTC by Paweł Hajdan, Jr. (RETIRED)
Modified: 2006-08-17 16:58 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
cups-1.1.patch (cups-1.1.patch,686 bytes, patch)
2006-07-29 05:51 UTC, Paweł Hajdan, Jr. (RETIRED)
Details | Diff
cups-1.2.patch (cups-1.2.patch,825 bytes, patch)
2006-07-29 05:52 UTC, Paweł Hajdan, Jr. (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2006-07-28 22:47:16 UTC
In my opinion the following blocks of einfos in the cups ebuild could me made conditional to make less noise for the user:

einfo "If you're using a USB printer, \"emerge coldplug; rc-update add"
einfo "coldplug boot\" is something you should probably do. This"
einfo "will allow any USB kernel modules (if present) to be loaded"
einfo "automatically at boot."

^-----> only if coldplug is not installed or not started

einfo "You need to emerge ghostscript with the cups-USEflag turned on"

^-----> only if it's not done (the check may be complicated, because ghostscript is a virtual, so feel free to ignore this suggestion)
Comment 1 Stefan Schweizer (RETIRED) gentoo-dev 2006-07-29 03:59:14 UTC
the coldplug einfo was removed in cups-1.2 as coldplug is no longer in use with recent udev.

if you want to write and test some code for the ghostscript USE then do so please.

if !( built_with_use ... || -gpl || -esp ; then ..
something like that

I will just close this as needinfo - feel free to reopen with a patch :)
Comment 2 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2006-07-29 05:51:24 UTC
Created attachment 92999 [details, diff]
cups-1.1.patch

patch for cups-1.* ebuilds
Comment 3 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2006-07-29 05:52:06 UTC
Created attachment 93000 [details, diff]
cups-1.2.patch

patch for cups-1.2.* ebuilds
Comment 4 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2006-07-29 05:52:58 UTC
reopening with patches for cups-1.1.* and cups-1.2.* ebuilds.
Comment 5 Stefan Schweizer (RETIRED) gentoo-dev 2006-08-17 16:58:51 UTC
sorry, must have forgotten about this in the holidays :(

committed the patch with slight modifications: einfo -> ewarn

thank you very much for contributing to Gentoo, hope to see you again