141926 – Trivial QA issues with sys-fs/ntfs3g ebuild.

Bug 141926 - Trivial QA issues with sys-fs/ntfs3g ebuild.

Summary: Trivial QA issues with sys-fs/ntfs3g ebuild.

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	High trivial
Assignee:	Patrick McLean

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2006-07-27 13:01 UTC by Samuli Suominen (RETIRED)
Modified:	2006-07-28 11:45 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Samuli Suominen (RETIRED) gentoo-dev

2006-07-27 13:01:01 UTC

- src_compile() should be removed because it doesn't do anything but defaults.
- make to emake in src_install()
- dodoc AUTHORS ChangeLog CREDITS NEWS README in src_install()

Thanks, drac

I don't mean to be annoying, but I posted this ebuild to forums same time you added different version to portage and these are pretty much all the differences they had. :-)

Comment 1 Jakub Moc (RETIRED) gentoo-dev

2006-07-27 13:12:57 UTC

BTW, blocks need to be mutual. If ntfs3g blocks ntfsprogs, ntfsprogs ebuild needs to block ntfs3g as well.

Comment 2 Patrick McLean gentoo-dev

2006-07-27 14:31:37 UTC

fixed.

Comment 3 Samuli Suominen (RETIRED) gentoo-dev

2006-07-28 03:59:22 UTC

dodoc AUTHORS ChangeLog CREDITS NEWS README 

in src_install() is still missing.

Comment 4 Samuli Suominen (RETIRED) gentoo-dev

2006-07-28 04:22:24 UTC

emake DESTDIR="${D}" install is missing..

|| die "emake install failed."

and those P.. MY_P.. settings could be used in SRC_URI too.

Comment 5 Patrick McLean gentoo-dev

2006-07-28 11:45:05 UTC

Fixed.