Bug 141799 – kde-misc/dolphin-0.6.0 (New Package)

• Status: VERIFIED FIXED
• Product: Gentoo Linux

[Description Konrad Zapalowicz 2006-07-26 08:08:01 UTC]

Hi,

Dolphin is a nice file manager for KDE. I haven't found it in portage so I wrote an ebuild for it.

Regards,
KZ.


-----
feel free to correct my english

[Comment 1 Konrad Zapalowicz 2006-07-26 08:10:27 UTC]

Created attachment 92785 [details]
dolphin-0.6.0 (New Package)

[Comment 2 Jakub Moc (RETIRED) 2006-07-26 08:14:52 UTC]

> DEPEND="|| (kde-base/kdebase =kde-base/kdebase-3.5* )"

What do you mean???

[Comment 3 Konrad Zapalowicz 2006-07-26 08:19:46 UTC]

(In reply to comment #2)
> > DEPEND="|| (kde-base/kdebase =kde-base/kdebase-3.5* )"
> 
> What do you mean???
> 

It means (I hope) that dolphin depends on kde at least in version 3.5.0.


-----
feel free to correct my english

[Comment 4 Jakub Moc (RETIRED) 2006-07-26 11:02:36 UTC]

Comment on attachment 92785 [details]
dolphin-0.6.0 (New Package)

(In reply to comment #3)
> (In reply to comment #2)
> > > DEPEND="|| (kde-base/kdebase =kde-base/kdebase-3.5* )"
> > 
> > What do you mean???
> > 
> 
> It means (I hope) that dolphin depends on kde at least in version 3.5.0.

No, not really. That's what need-kde 3.5 does. The above wrongly hardcoded monolithic KDE ebuilds there, needs to be fixed.

[Comment 5 Konrad Zapalowicz 2006-07-26 17:11:01 UTC]

Created attachment 92817 [details]
dolphin-0.6.0 (Update)

- Add postinstall info: how to switch from konq. to dolphin.
- Tried to fix dependencies mess, I hope now it is ok :)

[Comment 6 Konrad Zapalowicz 2006-08-02 04:06:58 UTC]

Looks like noone is intrested, so I decidet to remind about this ebuild, hope that's ok.

Regards,
KZ.

[Comment 7 Jakub Moc (RETIRED) 2006-08-08 13:53:55 UTC]

*** Bug 143244 has been marked as a duplicate of this bug. ***

[Comment 8 Jakub Moc (RETIRED) 2006-08-08 13:54:11 UTC]

Reopening this.

[Comment 9 Tiziano Müller (RETIRED) 2006-08-09 00:32:47 UTC]

Ok, I made a new ebuild for v0.6.1 and committed it to the gentoo-sunrise overlay. It will take some hours until it is reviewed, after that it will be available here:
http://gentoo-sunrise.org/svn/reviewed/kde-misc/dolphin

Konrad: If you would like to have some explanations what was wrong with your ebuild and why I did it the way I did, either drop me a note here or join the irc-channel #gentoo-sunrise on freenode.

[Comment 10 Jakub Moc (RETIRED) 2006-08-10 14:44:41 UTC]

Created attachment 93943 [details]
dolphin-0.6.1.ebuild

[Comment 11 Konrad Zapalowicz 2006-08-20 15:00:46 UTC]

> Konrad: If you would like to have some explanations what was wrong with your
> ebuild and why I did it the way I did, either drop me a note here or join the
> irc-channel #gentoo-sunrise on freenode.

Hi,
I would like to have some explanations :)

sorry for reply time but I was away from my PC for a few weeks.

Regards,
KZ.

[Comment 12 Tiziano Müller (RETIRED) 2006-08-21 12:30:57 UTC]

No problem :-)
What I corrected:
1) Instead of dolphin-${PV} in the SRC_URI you can simply use ${P}
2) The quotes around "${WORKDIR}/${PN}" are not needed (while they don't hurt either, but it is a style question and I like it without :-)
3) After some discussions on IRC and the mailinglist, it has been decided that RDEPEND should be set (at least for sunrise-ebuilds)
4) You don't have to depend on a specific version of kde if you have "need-kde ..."
5) according to my information, dolphin also works on kde-3.4
6) Don't use "echo" and don't add empty einfo lines
7) I don't think that this message is needed anyway :)

All in all it was a very good ebuild and needed less to make it ready. If you want, you can join gentoo-sunrise and take it over from me and maintain it there. More info: http://gentoo-sunrise.org

[Comment 13 Konrad Zapalowicz 2006-08-22 05:31:54 UTC]

> 5) according to my information, dolphin also works on kde-3.4

I heard that it works on 3.4 but never tested it on 3.4. The rule is: what is not tested, it is not working ;) so that I shipped it with 3.5 support.


> All in all it was a very good ebuild and needed less to make it ready. If you
> want, you can join gentoo-sunrise and take it over from me and maintain it
> there. More info: http://gentoo-sunrise.org

Thanks for words of praise :)
I'll try to contact You via IRC on #gentoo-sunrise shortly.

Regards,
KZ.


-----
feel free to correct my english

[Comment 14 Diego Elio Pettenò (RETIRED) 2006-09-21 22:07:48 UTC]

[I was pointed at dolphin as possible addition to the Portage tree, I'm going to take care of this today.]

A few notes on the sunrise ebuild, as it's not correct in respect to proper kde.eclass usage:

- kdeenablefinal useflag just need to be in IUSE, there's _no need_ to $(use_enable) it (the eclass takes care);
- kdelibs should not be in DEPEND/RDEPEND, the eclass takes care.

This makes the ebuild shorter and much more similar than a boilerplate kde ebuild.

The KDE 3.4/3.5 issue is no more important, as 3.4 is out of support already.


Note: please remove the ebuild in overlay as soon as the main portage version is in place.

[Comment 15 Diego Elio Pettenò (RETIRED) 2006-09-21 22:26:41 UTC]

Okay, cleaned up ebuild in portage now, thanks Konrad and Tiziano for the job :)

Please close the bug (as in CLOSED) when the ebuild is out of sunrise for safety.

[Comment 16 David Shakaryan (RETIRED) 2006-09-21 22:50:51 UTC]

I have removed it from Sunrise in revision 1297. I can't close the bug as I do not have access to it.

[Comment 17 Diego Elio Pettenò (RETIRED) 2006-09-21 22:53:14 UTC]

Thanks David :)