Hello Antarus, IIRC you are a treecleaner, right? I was about to create a new ebuild for it until I found out.. - upstream is dead for 2 years now, homepage is dead. cvs repository is empty. - it doesn't compile with -Wl,--as-needed - it uses xine backend by default -> segmentation fault. see bug 120376 - it's maintainer-needed - there is plenty working image viewers in portage - ebuild uses old formatting - ${FILESDIR} has patches against Debian ChangeLogs. really. :)
+ uses unstated gtk2 use flag in src_compile()
hmmm, this is the best program for browsing folders of images and videos that I've found so removing it will suck as I use it regularily. If I try and clean up the ebuild a bit will it be possible to keep it in Portage?
Created attachment 93323 [details] Editied to not use Xine and GTK2 is now a hard-dep. I've editied the ebuild so that now it doesn't build with Xine support (removed the flag and everything relating to it) but you still have video support with MPlayer because it was actually an "MPlayer OR Xine" choice, not both. GTK2 is now not a hidden useflag option and the interface is built by default with the new GTK rather than old. Afraid I can't really do anything about --as-needed as that's unsupported and beyond my abilities of basic text editing anyway. If you use this in the local overlay you need to copy the "files" folder from the official portage version.
Created attachment 93324 [details] pornview-0.2.0_pre1-r1.ebuild Removed a redundant line and got rid of the other unneeded patchfile.
Created attachment 93325 [details, diff] pornview-0.2.0_pre1-4.diff This is now the only file that needs to be in the "files" folder. Removed all the debian cruft too.
Isn't it possible to filter the --as-needed flag out of LDFLAGS so it compiles fine?
(In reply to comment #6) > Isn't it possible to filter the --as-needed flag out of LDFLAGS so it compiles > fine? > While possible, part of the problem is that this package has no upstream, another concern is does it compile with gcc-4.1 ? if not, that is another thing that I would like fixed if we are to keep this, as 4.1 will be stable soon. Packages with dead upstream are fun as all the problems then fall on us. If you like it; I am willing to proxy this package for you.
Compiles fine with GCC 4.1.1.
Created attachment 94520 [details, diff] traypatch.diff Patch from http://bugs.gentoo.org/show_bug.cgi?id=93500 to fix the tray issue.
Created attachment 94521 [details] pornview-0.2.0_pre1-r2.ebuild Updated the -r1 ebuild to make use of the tray patch.
Many thanks for your efforts Ben. esp the xinelib lockup crash . this was the main bug bear for me with this excellent prog.
Created attachment 94733 [details] patch to avoid having PORN slapped across your title bar simple patch for those who may wish to avoid the program name being displayed in the title bar. Handy if you want to use this excellent viewer to show your 9 year-old niece the pics of the new pups without having to explain to her what porn means.
Compiles here; but I'm on ppc64 (with gcc-3.X) so let me upgrade and double check on my x86 box.
Not dying; I'm the new maintainer; thanks a ton for your help, fixes are in -r1
