XChat needs a version bump. 2.6.6 was released on July 17th.
I've renamed the ebuild to 2.6.6 and removed the 2 patches that have been merged. Works without problems on ~x86
Created attachment 92477 [details] XChat 2.6.6 test ebuild
Confirmed compiling without issues and working fine on ~x86
Relevant? from http://forum.xchat.org/viewtopic.php?p=10809 Starting from 2.6.6, there are some build time options for spelling support. ./configure --enable-spell=type, Where type can be one of: none: No spelling support. *static: Include a statically compiled sexy-spell-entry. *libsexy: Link with -lsexy and use its spelling support. #gtkspell: Link with -lgtkspell and use its spelling support. This option changes the input box to a GtkTextView, which you may not like! * = Uses enchant as its dictionary. # = Uses aspell as its dictionary. Hopefully the packager for your distribution will choose the most appropriate option. If in doubt, choose static, because it doesn't require anything special!
Created attachment 92769 [details, diff] patch against xchat-2.6.4.ebuild in portage to get 2.6.6 ebuild So it looks like "--enable-spell" is no longer enough, it will say that spell is enabled but who knows which one (my bet is static or none :) I've changed it to set "--enable-spell=gtkspell" explicitly (as gtkspell is what xchat depends on for spell useflag). Note I used use_enable function with 3 arguments, which is not mentioned in devmanual so I dunno if it's correct to use, or just something new in portage-2.1.1_pre*. Found it by looking in ebuild.sh as it would make perfect sense for it to support 3 args like this :) Builds and runs fine on x86 with USE="dbus ipv6 mmx nls perl python spell ssl tcl xchatdccserver xchattext -debug -xchatnogtk"
Created attachment 93157 [details, diff] xchat-2.6.4-2.6.6_ebuild.diff What about something like this? It's all about choice in Gentoo. So why not let the user choose the spelling library?
We will always end up using enchant for spell checking. I'd go for just using the spell USE flag to use the static spell checking. It uses the same code as libsexy, without the need for additional dependencies. Looks a little bit nicer than gtkspell and we don't need to tinker around with a local USE flag.
Static stuff and no choice, not really Gentoo I think :) There's already local libsexy useflag for xchat-gnome, so why not here too. And xchat itself already has a number of local useflags, one more won't hurt :) So, I agree with comment 6.
Your choice is: none -> no spell checking, USE="-spell" static -> this actually is libsexy, but using the widget included with xchat, USE="spell" libsexy -> use libsexy, but just the spell widget from it, see above gtkspell -> use gtkspell, which doesn't look as nice as the sexy widget We add a (local) USE flag where it makes sense, not just because we can. You have the choice to have spell checking or not. You'll probably not notice whether the spell checking widget is static/libsexy or gtkspell. The spell checking engine is always wrapped by enchant and will work in all cases. xchat-gnome has a libsexy USE flag as it uses more from libsexy than just the spell checking. Once xchat starts using more from libsexy, we can talk about a local USE flag, but currently I don't see a reason for it.
