Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 14034 - make.conf variable usage not consistent and misc
Summary: make.conf variable usage not consistent and misc
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Nicholas Jones (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-01-16 08:51 UTC by Jared H. Hudson (RETIRED)
Modified: 2003-02-03 03:58 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jared H. Hudson (RETIRED) gentoo-dev 2003-01-16 08:51:45 UTC
Some variables in make.conf are FOO="foo" others are FOO=foo
I think they should all be made consistent.
Example changes:
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
DISTDIR="${PORTDIR}/distfiles"
PKGDIR="${PORTDIR}/packages"

PORT_LOGDIR="/var/log/emerge/"
Why's this one end with a / and the others don't?
PORTDIR_OVERLAY="/usr/local/portage"

FETCHCOMMAND="/usr/bin/proz --no-getch -s ${URI} -P ${DISTDIR}"
This was with 's instead of "s

AUTOCLEAN="yes"
This is the default now, isn't it? If so, we should show the non-default option
in the commented out part and or specify what's default above it in the comments.
Comment 1 Jared H. Hudson (RETIRED) gentoo-dev 2003-01-16 09:32:05 UTC
Spanky pointed out to me that most config files show the defaults commented out. 
(/etc/ssh/sshd_config does a lot of this for example)
So, if AUTOCLEAN="no" is the default (which according to man make.conf it is)
then that is what should be shown commented out. This also is consistent with
the path options that are commented out above AUTOCLEAN.

As for the rest of my proposed changes, they still are applicable as of
portage-2.0.46-r9
Comment 2 Nicholas Jones (RETIRED) gentoo-dev 2003-02-03 03:58:57 UTC
taken care of.