Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 140321 - app-portage/euses doesn't work in gentoo/alt
Summary: app-portage/euses doesn't work in gentoo/alt
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Other (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Jeroen Roovers (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-07-14 02:17 UTC by Timothy Redaelli (RETIRED)
Modified: 2006-12-05 03:23 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
My patch to fix euses source problem (euses-source.patch,480 bytes, patch)
2006-07-14 02:18 UTC, Timothy Redaelli (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Redaelli (RETIRED) gentoo-dev 2006-07-14 02:17:34 UTC
Hi,
euses doesn't work on gentoo/alt (source command not exist in /bin/sh),
i attach a patch that resolves that problem (yes, it works also in linux).
Comment 1 Timothy Redaelli (RETIRED) gentoo-dev 2006-07-14 02:18:25 UTC
Created attachment 91690 [details, diff]
My patch to fix euses source problem
Comment 2 Fabian Groffen gentoo-dev 2006-07-14 13:46:35 UTC
euse is completely broken on OSX because readlink seems to expect other input.  What gentoo/alt system are you using?
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2006-07-14 13:50:57 UTC
(In reply to comment #2)
> euse is completely broken on OSX because readlink seems to expect other input. 
> What gentoo/alt system are you using?

euses, not euse. I cannot test this myself, sadly, though I am euses' maintainer and upstream. I might be able to support Gentoo/Alt with your help, though. Could you look at the patch? I guess this is a patch against app-portage/euses-2.4.3, which should at the least compile properly.
Comment 4 Timothy Redaelli (RETIRED) gentoo-dev 2006-07-14 14:46:48 UTC
(In reply to comment #3)
> (In reply to comment #2)
> > euse is completely broken on OSX because readlink seems to expect other input. 
> > What gentoo/alt system are you using?
> 
> euses, not euse. I cannot test this myself, sadly, though I am euses'
> maintainer and upstream. I might be able to support Gentoo/Alt with your help,
> though. Could you look at the patch? I guess this is a patch against
> app-portage/euses-2.4.3, which should at the least compile properly.

also 2.5.0_pre1 works
Comment 5 Fabian Groffen gentoo-dev 2006-07-15 01:09:58 UTC
(In reply to comment #4)
> also 2.5.0_pre1 works

Based on the patch in you other bug, you are on a x86-fbsd system?!?

@jer: euses has depend on autoconf-wrapper, which I cannot keyword on OSX, so I won't even get to compiling the thing.
Comment 6 Timothy Redaelli (RETIRED) gentoo-dev 2006-07-15 02:20:48 UTC
(In reply to comment #5)
> (In reply to comment #4)
> > also 2.5.0_pre1 works
> 
> Based on the patch in you other bug, you are on a x86-fbsd system?!?
> 
> @jer: euses has depend on autoconf-wrapper, which I cannot keyword on OSX, so I
> won't even get to compiling the thing.
> 

Yes, i am on x86-fbsd
Comment 7 Jeroen Roovers (RETIRED) gentoo-dev 2006-11-17 21:14:29 UTC
Try 2.5.0. It should be able to figure out by itself where bash is.
Comment 8 Fabian Groffen gentoo-dev 2006-11-18 01:43:56 UTC
I tried patching it, but maybe upstream can first use their define EMF in euses.c, such that a one place change actually reflects a change in all other locations.

e.g.:

popen("source /etc/make.globals;"
          "source /etc/make.conf;" "echo -n ${PORTDIR}", "r");

to

popen("source " ETC "/make.globals;"
          "source " EMF ";" "echo -n ${PORTDIR}", "r");

or

popen("source " ETC "/make.globals;"
          "source " ETC "/make.conf;" "echo -n ${PORTDIR}", "r");

Maybe you better run eautoreconf as upstream, and if you do in the ebuild, in src_unpack would be better.
Comment 9 Jeroen Roovers (RETIRED) gentoo-dev 2006-11-18 04:50:20 UTC
Let's try a different approach: today I (upstream for euses) committed app-portage/euses-2.5.0 to the tree. It finds bash on its own so you might want to try this version (the final >>>app-portage/euses-2.5.0<<< to be precice, not the preview) and see if the problem is solved. Hint: emerge -u euses.


Kind regards,
     JeR
Comment 10 Fabian Groffen gentoo-dev 2006-11-18 06:40:40 UTC
hint:
please || die "I'm not interested in bash"
Comment 11 Jeroen Roovers (RETIRED) gentoo-dev 2006-11-18 13:49:34 UTC
(In reply to comment #10)
> hint:
> please || die "I'm not interested in bash"

How very blunt of you. I don't think you are cooperating very well. Did you really intend to be this uninformative?

If you would kindly tell me what exactly it is that BSD/OSX needs, I would happily implement it. Some of the questions you never answered are:

1) Are you telling me the script would work with any sh (that is not bash)?
2) Which shells would you like me to test with?
2) Does BSD/OSX support eautoreconf these days?


Kind regards,
     JeR
Comment 12 Jeroen Roovers (RETIRED) gentoo-dev 2006-11-18 14:29:33 UTC
2.5.0-r1 is in the tree with all your suggested fixes. Please test (and possibly mark ~arch if you want to).
Comment 13 Fabian Groffen gentoo-dev 2006-11-19 04:25:11 UTC
Ok, maybe my comment wasn't too polite, I'm sorry for that.  Anyhow, you're not polite at all, so I don't care at all to get euses to _function_ correcty, as it _compiles_ fine, but _runs_ only if you have /etc/make.conf and /etc/make.globals.  Your package simply doesn't respect the --sysconfdir= configure flag.
Comment 14 Jeroen Roovers (RETIRED) gentoo-dev 2006-11-19 12:03:34 UTC
(In reply to comment #13)
> Ok, maybe my comment wasn't too polite, I'm sorry for that.  Anyhow, you're not
> polite at all, so I don't care at all to get euses to _function_ correcty, as
> it _compiles_ fine, but _runs_ only if you have /etc/make.conf and
> /etc/make.globals.  Your package simply doesn't respect the --sysconfdir=
> configure flag.

Anything else I need to address to get it it to work?
Comment 15 Jeroen Roovers (RETIRED) gentoo-dev 2006-11-19 22:28:00 UTC
2.5.1 is in the tree. It uses $sysconfdir to find the paths to make.{conf,globals}. Plztstk?
Comment 16 Fabian Groffen gentoo-dev 2006-11-25 13:13:50 UTC
% euses -V
euses 2.5.3
Copyright Jeroen Roovers 2005-2006 - Please report bugs to jer@gentoo.org
This is Free Software (see /Library/Gentoo/usr/portage/licenses/GPL-2)

looks good.  Added ~ppc-macos in prefix.
Comment 17 Jeroen Roovers (RETIRED) gentoo-dev 2006-11-26 13:46:25 UTC
(In reply to comment #16)
> % euses -V
> euses 2.5.3
> Copyright Jeroen Roovers 2005-2006 - Please report bugs to jer@gentoo.org
> This is Free Software (see /Library/Gentoo/usr/portage/licenses/GPL-2)
> 
> looks good.  Added ~ppc-macos in prefix.

Thank you. Does this mean all is set to close this bug as RESOLVED/FIXED?
Comment 18 Fabian Groffen gentoo-dev 2006-11-26 13:48:40 UTC
The prefix part from Gentoo/Alt is RESOLVED/FIXED.  Don't know how the BSD part is doing.
Comment 19 Timothy Redaelli (RETIRED) gentoo-dev 2006-12-05 03:23:20 UTC
Since i keyworded it i think it's possibile to close this bug.