Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 140297 - hddtemp: improved option passing + safer defaults for daemon mode
Summary: hddtemp: improved option passing + safer defaults for daemon mode
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Michal Januszewski (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-07-13 21:53 UTC by Marek Szuba
Modified: 2006-07-14 18:12 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
hddtemp-confext.patch (hddtemp-confext.patch,998 bytes, patch)
2006-07-13 21:53 UTC, Marek Szuba
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marek Szuba archtester gentoo-dev 2006-07-13 21:53:01 UTC
Attached you will find a patch against /etc/(conf|init).d/hddtemp which does two things:

- the original conf.d file had key called HDDTEMP_OPTS which was in fact used to specify drives to monitor, although it was possible to use it for option passing too if one kept them in appropriate order. Now there are two separate keys, HDDTEMP_OPTS for command line options (parsed first in the init script) and HDDTEMP_DRIVES for drive names (parsed second). This should make it easier to avoid having someone put an option after the name of the disc and thus mess up the daemon's startup.

 - makes the aformentioned conf.d file make the daemon listen on loopback only by default. No point in having this class of information published to the whole network unless such behaviour is explicitly demanded by the user, especially in light of lack of authentication of the hddtemp protocol.
Comment 1 Marek Szuba archtester gentoo-dev 2006-07-13 21:53:58 UTC
Created attachment 91679 [details, diff]
hddtemp-confext.patch
Comment 2 Michal Januszewski (RETIRED) gentoo-dev 2006-07-14 18:12:30 UTC
I've added the changed files to CVS. Thanks :)