Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 140144 - samba-3.0.23 ebuild changes needed
Summary: samba-3.0.23 ebuild changes needed
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal
Assignee: Gentoo's SAMBA Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-07-12 12:04 UTC by Chris Smith
Modified: 2006-07-24 05:52 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
diff to handle some samba 3.0.23 changes (samba-3.0.23.ebuild.diff,2.45 KB, patch)
2006-07-12 12:05 UTC, Chris Smith
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Smith 2006-07-12 12:04:03 UTC
There are changes with samba-3.0.23 that don't appear to addresses by the current ebuild:

xml, ldapsam, and sql backends are gone from samba proper with sql backends available separately

ebuild diff attached - this will not handle sql backends but does fix bug #134477

Chris
Comment 1 Chris Smith 2006-07-12 12:05:50 UTC
Created attachment 91591 [details, diff]
diff to handle some samba 3.0.23 changes
Comment 2 Andrei Slavoiu 2006-07-12 12:23:56 UTC
You lost $(use_with kerberos ads) in your patch.
Comment 3 Jakub Moc (RETIRED) gentoo-dev 2006-07-12 12:25:28 UTC
How about reading the changelog?
Comment 4 Chris Smith 2006-07-12 12:48:20 UTC
(In reply to comment #2)
> You lost $(use_with kerberos ads) in your patch.
> 

I don't think it's needed. I you set the kerberos use flag samba will automatically configure for ads.
Comment 5 Chris Smith 2006-07-12 12:52:47 UTC
(In reply to comment #3)
> How about reading the changelog?
> 

Why doesn't the ebuild reflect the changes?

Seems that it should. Or am I mistaken?

The unused use flags are still there.
Configure options that no longer exist are being passed.
And there is no download of the third party source for sql backends (and again the use flags are still there for them).

Comment 6 Christian Andreetta (RETIRED) gentoo-dev 2006-07-13 07:01:19 UTC
well, in your patch you lost a bit of ldap...
but you're right: those use flags have to be removed.
I just wanted to wait for xml and *sql support requests: for now, the ebuild doesn't support them. In a few days, if nobody raises the issue, they will be removed. If the use flags are present, however, there will be no problem during compilation/install 
Comment 7 Chris Smith 2006-07-13 09:45:07 UTC
(In reply to comment #6)
> well, in your patch you lost a bit of ldap...

I'm missing why you say this as ldapsam to support samba-2.2 ldap compatibility is now kaput. Plus, the way it was previously handled caused bug #134477 as --without-ldap would never get sent to configure.

I suppose the ads use flag could have been left in but if kerberos and ldap are set ads support will build automatically. I suppose someone may want kerberos and ldap support without ads but it's possibly unlikely, although it may be best to retain such flexibility.

Even though I removed the 'mymods' section, $(use_with ldap) was added.
Did I miss something vital regarding ldap?

Of course, I sidestepped the whole sql backend issue by removing those sections but that issue is beyond my skill level :)

And BTW, I appreciate all of the excellent work you do maintaining the package, especially getting these releases out on a timely basis. Not trying to get in your hair, just trying to assist when I can. 

Chris
Comment 8 Christian Andreetta (RETIRED) gentoo-dev 2006-07-24 05:52:44 UTC
I'd like to keep the "ads" check. On all the other parts, I like your suggestions: implementing them in 3.0.23a (no one complained about the *sql and xml backends missing).
Reporting here a small talk already had privately: an ebuild is GPL-ed, so it belongs to all the community. Everyone has the right to enhance it: packages require sometimes a lot of steps to install, and if a user has a good idea on one of these steps, it is very welcomed.