Hi This is a revised ebuild of the pftpfxp package. I've made a patch to correct the error where the config files can not be found. The program didn't look in the ~/ folder. It looked in the same folder as the binary. My patch corrects this problem. /Daniel Persson
Created attachment 91589 [details] pftpfxp-0.11.4.6-r2.ebuild
Comment on attachment 91589 [details] pftpfxp-0.11.4.6-r2.ebuild The new revision of the ebuild
Created attachment 91590 [details, diff] 0.11.4.6-correct_config_fix.patch Patch to correct the problem. All the old patched from previous revisions should still be available.
I didn't like the buffer overflow possibilities with your patch so I created my own. Same effect. Also patched error to stderr. If this breaks things let me know and i'll fix it. Thanks Daniel
Created attachment 92868 [details, diff] Patch This is a patch to fix the problem where pftp looks for the bookmarks file in the wrong place.
(In reply to comment #5) > Created an attachment (id=92868) [edit] > Patch > > This is a patch to fix the problem where pftp looks for the bookmarks file in > the wrong place. > looks almost ok. Needs to free the memory it allocated. Use free(ptr) after the last useage of ptr. Please reattach patch. Also, for next time can you do a new bug after bug is resolved. if its the same bug that hasn't been fixed it should be reopened instead. Just makes tracking a lot easier to deal with open bugs.
Created attachment 92893 [details, diff] 0.11.4.6-correct_bookmark_path.patch Hi This is the new patch with it freeing the allocated memory when its done using it.
Created attachment 92928 [details, diff] 0.11.4.6-correct_bookmark_path.patch A new patch to fix all cases of free() :)
(In reply to comment #8) > A new patch to fix all cases of free() :) Well except if the first malloc suceededs and the second runs out of memory :-). hmm. not likely and it exits anyway. Thanks Daniel and keep up the good work.
