Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 140093 - media-fonts/pcf2bdf fails on gzipped files (was: ~amd64 request)
Summary: media-fonts/pcf2bdf fails on gzipped files (was: ~amd64 request)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: High normal (vote)
Assignee: Gentoo Fonts Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-07-12 03:21 UTC by Jan Gutter
Modified: 2006-10-23 04:55 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
64bit patch for pcf2bdf (pcf2bdf-1.04-amd64.patch,8.64 KB, patch)
2006-07-12 03:30 UTC, Jan Gutter
Details | Diff
ebuild to apply the patch (pcf2bdf-1.04-r1.ebuild,815 bytes, text/plain)
2006-07-12 03:31 UTC, Jan Gutter
Details
pcf2bdf-1.04-gzip.patch (pcf2bdf-1.04-gzip.patch,419 bytes, text/plain)
2006-10-08 12:15 UTC, Christoph Mende (RETIRED)
Details
pcf2bdf-1.04-r1.ebuild (pcf2bdf-1.04-r1.ebuild,837 bytes, text/plain)
2006-10-08 12:15 UTC, Christoph Mende (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Gutter 2006-07-12 03:21:05 UTC
I went through media-fonts last night and found this "shortish" program that hasn't been unmasked for amd64. I created a patch, but I would really love some testing by both amd64 people and x86 guys.

-- What I did --

I used inttypes.h to get the cross-platform standard size variables and printf macros. Then I went through all the printf's and made sure the variables match the format string. This patch should, in essence, not affect x86 at all. Please test!

I don't use this program myself, but it seemed easy enough to port (no pointer funkyness, arithmetic problems, etc.)
Comment 1 Jan Gutter 2006-07-12 03:30:50 UTC
Created attachment 91555 [details, diff]
64bit patch for pcf2bdf
Comment 2 Jan Gutter 2006-07-12 03:31:48 UTC
Created attachment 91556 [details]
ebuild to apply the patch
Comment 3 Simon Stelling (RETIRED) gentoo-dev 2006-10-08 10:12:25 UTC
The patch is in, thanks for this excellent piece of work. It seems to work fine for .pcf files, but when they are gzip compressed, it fails:

# pcf2bdf -o blubb term14.pcf.gz
pcf2bdf: failed to execute gzip
# gunzip term14.pcf.gz
#

I'd really like to get this issue fixed before I go and add the ~amd64 keyword. Please feel free to reopen the bug with a patch that fixes said issue.

Thanks!
Comment 4 Christoph Mende (RETIRED) gentoo-dev 2006-10-08 12:15:19 UTC
Created attachment 99148 [details]
pcf2bdf-1.04-gzip.patch

here comes the patch
Comment 5 Christoph Mende (RETIRED) gentoo-dev 2006-10-08 12:15:54 UTC
Created attachment 99149 [details]
pcf2bdf-1.04-r1.ebuild

and here comes the ebuild
Comment 6 Christoph Mende (RETIRED) gentoo-dev 2006-10-08 12:17:51 UTC
aaaaand reopening
Comment 7 Simon Stelling (RETIRED) gentoo-dev 2006-10-08 12:27:40 UTC
fonts herd - please see comment 3 and comment 4/5. If you don't complain within a week I'll go on and commit the fix as its fairly simple.
Comment 8 Simon Stelling (RETIRED) gentoo-dev 2006-10-23 04:55:55 UTC
a week has been over for about a week now, so this is fixed ;) thanks both of you for the patches