Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 139820 - x11-misc/xvkbd: cleanup for correct support of modular X
Summary: x11-misc/xvkbd: cleanup for correct support of modular X
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Desktop Misc. Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-07-09 15:01 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2006-07-10 10:51 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Ebuild patch (xvkb-ebuild.patch,1.28 KB, patch)
2006-07-09 15:02 UTC, Diego Elio Pettenò (RETIRED) 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2006-07-09 15:01:02 UTC 
The attached patch improves support of modular x in xvkbd by pinpointing the deps, and using the correct appdefaultsdir for both modular and monolithic.

As I was there, I also fixed it so that LDFLAGS is actually respected and cleaned up the dependencies after linking with --as-needed.

HTH,
Diego
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2006-07-09 15:02:09 UTC 
Created attachment 91319 [details, diff]
Ebuild patch
Comment 2 Diego Elio Pettenò (RETIRED) gentoo-dev 2006-07-10 03:24:48 UTC 
Sorry there's a typo in the patch, it should be libXmu not Xmu, simple to fix tho :)
Comment 3 Krzysztof Pawlik (RETIRED) gentoo-dev 2006-07-10 08:50:31 UTC 
flameeyes: feel free to apply it in portage :)
Comment 4 Diego Elio Pettenò (RETIRED) gentoo-dev 2006-07-10 10:51:02 UTC 
Thanks, I've committed it now :)