Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 139783 - eutils.eclass: ebeep / esleep never do something with portage 2.1
Summary: eutils.eclass: ebeep / esleep never do something with portage 2.1
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-07-09 09:09 UTC by Matthias Schwarzott
Modified: 2006-07-15 12:27 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Schwarzott gentoo-dev 2006-07-09 09:09:21 UTC
The functions ebeep and esleep contain this check at the start:

--cut
if [ -z "$EBEEP_IGNORE" ] && [ -t 1 ] ; then
--cut

This check will fail always as [ -t 1 ] always deliver false in ebuilds with portage 2.1.
Checked with command tty shows that file-descriptor 1 is connected to a pseudo-terminal (/dev/pts/[0-9]+) now.

Solution: Either just remove the [ -t 1 ], or implement a better check for the existance of a propper output-device ( with attached user :) ).
Comment 1 Ciaran McCreesh 2006-07-15 06:55:23 UTC
Are you using that fancy new logging stuff?
Comment 2 Matthias Schwarzott gentoo-dev 2006-07-15 09:08:18 UTC
No, have not yet activated any new logging system.
Comment 3 Ciaran McCreesh 2006-07-15 10:08:08 UTC
Hrm. I guess 2.1 always uses the ugly tee hack, rather than just when running under Catalyst. Ok, someone should probably just nuke the -t check.
Comment 4 SpanKY gentoo-dev 2006-07-15 12:27:00 UTC
done, cheers